- fixed: endgame menu no longer resets player's userinfo

User CVARs can be stored in member variables for quicker access
Unconditional call to G_CheckDemoStatus() destructs and recreates such CVARs
Dangling pointers could be accessed during the last game tick, e.g. from event handlers

https://forum.zdoom.org/viewtopic.php?t=65150

src/menu/messagebox.cpp

@@ -135,7 +135,8 @@ void ActivateEndGameMenu()
 		M_ClearMenus();
 		if (!netgame)
 		{
-			G_CheckDemoStatus();
+			if (demorecording)
+				G_CheckDemoStatus();
 			D_StartTitle();
 		}
 	});