From 46270326be797bc2493ea53958cd4d3a8b9f50d5 Mon Sep 17 00:00:00 2001 From: "alexey.lysiuk" Date: Sat, 5 Oct 2019 14:47:36 +0300 Subject: [PATCH] - implemented str(n)icmp function definitions via CMake macro --- CMakeLists.txt | 16 ++++++++++++++++ libraries/oplsynth/CMakeLists.txt | 14 ++------------ libraries/timidity/CMakeLists.txt | 8 +------- libraries/wildmidi/CMakeLists.txt | 14 ++------------ libraries/zmusic/CMakeLists.txt | 12 ++---------- src/CMakeLists.txt | 11 ++--------- 6 files changed, 25 insertions(+), 50 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index e2efc5ffe..aa74b5761 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -156,6 +156,22 @@ macro( use_fast_math ) set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${ZD_FASTMATH_FLAG}" ) endmacro() +include( CheckFunctionExists ) + +macro( require_stricmp ) + CHECK_FUNCTION_EXISTS( stricmp STRICMP_EXISTS ) + if( NOT STRICMP_EXISTS ) + add_definitions( -Dstricmp=strcasecmp ) + endif() +endmacro() + +macro( require_strnicmp ) + CHECK_FUNCTION_EXISTS( strnicmp STRNICMP_EXISTS ) + if( NOT STRNICMP_EXISTS ) + add_definitions( -Dstrnicmp=strncasecmp ) + endif() +endmacro() + option( NO_OPENAL "Disable OpenAL sound support" OFF ) find_package( BZip2 ) diff --git a/libraries/oplsynth/CMakeLists.txt b/libraries/oplsynth/CMakeLists.txt index d2a363ceb..379e72f83 100644 --- a/libraries/oplsynth/CMakeLists.txt +++ b/libraries/oplsynth/CMakeLists.txt @@ -1,24 +1,14 @@ cmake_minimum_required( VERSION 2.8.7 ) use_fast_math() +require_stricmp() +require_strnicmp() if( ZD_CMAKE_COMPILER_IS_GNUC_COMPATIBLE ) set( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -Wno-unused-parameter -fomit-frame-pointer" ) set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11" ) endif() -include( CheckFunctionExists ) - -CHECK_FUNCTION_EXISTS( stricmp STRICMP_EXISTS ) -if( NOT STRICMP_EXISTS ) - add_definitions( -Dstricmp=strcasecmp ) -endif() - -CHECK_FUNCTION_EXISTS( strnicmp STRNICMP_EXISTS ) -if( NOT STRNICMP_EXISTS ) - add_definitions( -Dstrnicmp=strncasecmp ) -endif() - include_directories( oplsynth ) file( GLOB HEADER_FILES diff --git a/libraries/timidity/CMakeLists.txt b/libraries/timidity/CMakeLists.txt index 632c5b8bd..fd80ba16e 100644 --- a/libraries/timidity/CMakeLists.txt +++ b/libraries/timidity/CMakeLists.txt @@ -1,19 +1,13 @@ cmake_minimum_required( VERSION 2.8.7 ) use_fast_math() +require_stricmp() if( ZD_CMAKE_COMPILER_IS_GNUC_COMPATIBLE ) set( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -Wno-unused-parameter -fomit-frame-pointer" ) set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11" ) endif() -include( CheckFunctionExists ) - -CHECK_FUNCTION_EXISTS( stricmp STRICMP_EXISTS ) -if( NOT STRICMP_EXISTS ) - add_definitions( -Dstricmp=strcasecmp ) -endif() - include_directories( timidity ) file( GLOB HEADER_FILES diff --git a/libraries/wildmidi/CMakeLists.txt b/libraries/wildmidi/CMakeLists.txt index e291526fe..98103bac2 100644 --- a/libraries/wildmidi/CMakeLists.txt +++ b/libraries/wildmidi/CMakeLists.txt @@ -1,24 +1,14 @@ cmake_minimum_required( VERSION 2.8.7 ) use_fast_math() +require_stricmp() +require_strnicmp() if( ZD_CMAKE_COMPILER_IS_GNUC_COMPATIBLE ) set( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -Wno-unused-parameter -fomit-frame-pointer" ) set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11" ) endif() -include( CheckFunctionExists ) - -CHECK_FUNCTION_EXISTS( stricmp STRICMP_EXISTS ) -if( NOT STRICMP_EXISTS ) - add_definitions( -Dstricmp=strcasecmp ) -endif() - -CHECK_FUNCTION_EXISTS( strnicmp STRNICMP_EXISTS ) -if( NOT STRNICMP_EXISTS ) - add_definitions( -Dstrnicmp=strncasecmp ) -endif() - include_directories( wildmidi ) file( GLOB HEADER_FILES diff --git a/libraries/zmusic/CMakeLists.txt b/libraries/zmusic/CMakeLists.txt index 87940544a..076c0b0f5 100644 --- a/libraries/zmusic/CMakeLists.txt +++ b/libraries/zmusic/CMakeLists.txt @@ -1,6 +1,8 @@ cmake_minimum_required( VERSION 2.8.7 ) use_fast_math() +require_stricmp() +require_strnicmp() if( ZD_CMAKE_COMPILER_IS_GNUC_COMPATIBLE ) set( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -Wno-unused-parameter -fomit-frame-pointer" ) @@ -9,16 +11,6 @@ endif() include( CheckFunctionExists ) -CHECK_FUNCTION_EXISTS( stricmp STRICMP_EXISTS ) -if( NOT STRICMP_EXISTS ) - add_definitions( -Dstricmp=strcasecmp ) -endif() - -CHECK_FUNCTION_EXISTS( strnicmp STRNICMP_EXISTS ) -if( NOT STRNICMP_EXISTS ) - add_definitions( -Dstrnicmp=strncasecmp ) -endif() - if( DYN_SNDFILE) add_definitions( -DHAVE_SNDFILE -DDYN_SNDFILE ) else() diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 1366aa53a..cd7bb6911 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -401,15 +401,8 @@ if( NOT STRUPR_EXISTS ) add_definitions( -DNEED_STRUPR=1 ) endif() -CHECK_FUNCTION_EXISTS( stricmp STRICMP_EXISTS ) -if( NOT STRICMP_EXISTS ) - add_definitions( -Dstricmp=strcasecmp ) -endif() - -CHECK_FUNCTION_EXISTS( strnicmp STRNICMP_EXISTS ) -if( NOT STRNICMP_EXISTS ) - add_definitions( -Dstrnicmp=strncasecmp ) -endif() +require_stricmp() +require_strnicmp() if( NOT MSVC ) add_definitions( -D__forceinline=inline )