1cdeebef37
While `fopen` (used through the macro `FLUID_FOPEN`) uses UTF-8 on *nix, it's restricted to ANSI on Windows. A change to enable using paths containing non-ANSI characters was suggested before in issue #128 but was rejected due to requiring large parts of both the public API and private implementation to be modified to accommodate Windows. This PR instead changes the macro definition for `FLUID_FOPEN` from `fopen` to a new wrapper, `fluid_fopen`. This wrapper is defined in `fluidsynth_priv.h` and defined in `fluid_sys.c` (following the pattern of `fluid_alloc`). Under Windows, it converts the `const char*` UTF-8 parameters to Unicode `wchar_t*` strings using the Windows API function `MultiByteToWideChar` and opens the file using the Windows API-specific `_wfopen`. On all other platforms, it simply calls `fopen`. The public API is unchanged. This solution will require Windows users of the API to convert UTF-16 strings to UTF-8 (which then get converted back into UTF-16 anyway), but that's still an improvement over only being able to use ANSI paths. This PR also adds a new test, `test_utf8_open`, which tests `FLUID_FOPEN` directly and through `fluid_is_soundfont` and `fluid_synth_sfload` using a new soundfont file, `sf2/â– VintageDreamsWaves-v2â– .sf2`, which is just a copy of `VintageDreamsWaves-v2.sf2` with Unicode characters in the filename. |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| README.md | ||
| test.h | ||
| test_bug_635.c | ||
| test_ct2hz.c | ||
| test_jack_obtaining_synth.c | ||
| test_pointer_alignment.c | ||
| test_preset_pinning.c | ||
| test_preset_sample_loading.c | ||
| test_sample_cache.c | ||
| test_sample_rate_change.c | ||
| test_sample_validate.c | ||
| test_seq_event_queue_remove.c | ||
| test_seq_event_queue_sort.c | ||
| test_seq_evt_order.c | ||
| test_seq_scale.c | ||
| test_seqbind_unregister.c | ||
| test_sf3_sfont_loading.c | ||
| test_sfont_loading.c | ||
| test_snprintf.c | ||
| test_synth_chorus_reverb.c | ||
| test_synth_process.c | ||
| test_utf8_open.c | ||
This directory contains small executables to verify fluidsynths correct behaviour, i.e. unit tests.
Do not blindly use the tests as template for your application!
Although some tests might serve as educational demonstration of how to use certain parts of fluidsynth, they are not intended to do so! It is most likely that those tests will consist of many hacky parts that are necessary to test fluidsynth (e.g. including fluidsynth's private headers to access internal data types and functions). For user applications this programming style is strongly discouraged! Keep referring to the documentation and code examples listed in the API documentation.
Developers
To add a unit test just duplicate an existing one, give it a unique name and update the CMakeLists.txt by
- adding a call to
ADD_FLUID_TEST()and - a dependency to the custom
checktarget.
Execute the tests via make check. Unit tests should use the VintageDreamsWaves-v2.sf2 as test soundfont.
Use the TEST_SOUNDFONT macro to access it.