Commit graph

1006 commits

Author SHA1 Message Date
R. Mattes
38758c78dd Fixed nasty loop test 2017-10-22 18:47:00 +02:00
derselbst
36d8f95584 avoid accessing uninited memory 2017-10-22 16:19:04 +02:00
derselbst
2623f67865 correctly fix use-after-free 2017-10-22 15:00:51 +02:00
derselbst
a54dfa522a remove G_STMT_[START|END]
for readability
2017-10-22 14:45:16 +02:00
derselbst
77ad959913 remove unused fluid_debug() 2017-10-22 14:43:35 +02:00
derselbst
02bb14243a remove unused debug enum 2017-10-22 14:41:00 +02:00
derselbst
3d7465a01e remove FLUID_STMT_[START|END]
for readability
2017-10-22 14:39:06 +02:00
derselbst
2deffc40c0 remove redundant #ifdef LADSPA
cmake will take care of compiling fluid_ladspa.c
2017-10-22 14:31:57 +02:00
derselbst
456b6afa97 remove redundant getopt.h declarations 2017-10-22 13:25:25 +02:00
Marcus Weseloh
799f3ea44c Merge pull request #242 from mawe42/ladspa-additional-fixes
More fixes to LADSPA system
2017-10-22 11:38:37 +02:00
Marcus Weseloh
e18e54d7ae White-space 2017-10-22 11:24:25 +02:00
Marcus Weseloh
e0dcdbcdfc Correct documentation for fluid_ladspa_run 2017-10-22 11:24:25 +02:00
Marcus Weseloh
47d640571b Add missing check for ladspa_is_active to ladsap_control_defaults 2017-10-22 11:24:25 +02:00
Marcus Weseloh
29a4abb9a5 Use int for number of inputs and outputs, some plugins have a lot of ports 2017-10-22 11:24:25 +02:00
derselbst
24614d343d Revert "ladspa: atomically get and set pending_deactivation"
This reverts commit 6c69b8ccff.
2017-10-22 11:23:34 +02:00
Tom M
7146ecd61b Merge pull request #239 from carlo-bramini/fluidsynth_no_glib_1
Fluidsynth no glib 1
2017-10-22 08:47:56 +02:00
Tom M
de617dd1f3 Merge pull request #240 from mawe42/ladspa-port-defaults
Add support for LADSPA control port defaults
2017-10-22 08:41:36 +02:00
Marcus Weseloh
8aa2d14476 Nicer error message when user requests LADSPA but is not available. 2017-10-21 22:40:19 +02:00
Marcus Weseloh
3cc684e47e Avoid a few ifdefs by defining two separate sets of node<->buffer functions 2017-10-21 22:36:34 +02:00
Marcus Weseloh
4d256ce8cc Add new command to FluidSynth shell to set control ports to default value 2017-10-21 19:49:49 +02:00
Marcus Weseloh
2787b0e10e Add function to automatically set unconnected port to default value
Uses the hints in the plugin to determine the default value.
2017-10-21 19:47:03 +02:00
Marcus Weseloh
7534e54d4f Check LADSPA setup before activation 2017-10-21 19:47:03 +02:00
carlo-bramini
828fdb9744 Completely remove G_STMT_* macros 2017-10-21 19:46:32 +02:00
derselbst
3486bb515b avoid null deref in jack driver 2017-10-21 19:30:09 +02:00
derselbst
c205e0162d avoid null dereferences in delete_fluid_ladspa_plugin()
be extremely paranoid as suggested by clang-tidy
2017-10-21 19:01:07 +02:00
carlo-bramini
6f7ec3b1fc Added FLUID_STMT_START and FLUID_STMT_END 2017-10-21 18:40:57 +02:00
carlo-bramini
031c3671da Replace GPOINTER_TO_INT with FLUID_POINTER_TO_INT 2017-10-21 18:33:27 +02:00
carlo-bramini
122b249e27 Replace G_INT_TO_POINTER with FLUID_INT_TO_POINTER 2017-10-21 18:32:17 +02:00
derselbst
6c69b8ccff ladspa: atomically get and set pending_deactivation 2017-10-21 18:31:20 +02:00
carlo-bramini
82454b9fd5 Remove useless code, it's identical for both LE & BE 2017-10-21 18:29:18 +02:00
carlo-bramini
7e238c5438 Replace g_atomic_*() with fluid_atomic_*() 2017-10-21 18:26:55 +02:00
carlo-bramini
3cea11de7f Replace use of glib types 2017-10-21 18:23:23 +02:00
derselbst
81505b9324 remove redundant ';' 2017-10-21 18:22:19 +02:00
derselbst
402f76bfb8 avoid duplicate ';' 2017-10-21 18:21:03 +02:00
derselbst
1d0cfd605f prefer using enum for LADSPA state 2017-10-21 18:13:40 +02:00
derselbst
4911bc8de4 credit @mawe42 for rewriting LADSPA 2017-10-21 18:09:38 +02:00
derselbst
79cef163a1 fix cast operator precedence 2017-10-21 18:05:54 +02:00
Tom M
53e8e27049 Merge pull request #238 from carlo-bramini/fluidsynth-on-mcu-1
Fluidsynth on mcu 1
2017-10-21 17:39:19 +02:00
Tom M
c594bdf466 Merge branch 'master' into fluidsynth-on-mcu-1 2017-10-21 17:38:54 +02:00
Tom M
0600ba7c68 Merge pull request #235 from mawe42/ladspa-cleanup
LADSPA effect unit refactor
2017-10-21 17:36:04 +02:00
Marcus Weseloh
9f4c60c6c8 Remove unused includes 2017-10-21 17:18:05 +02:00
carlo-bramini
931e4349a6 Reverted again to unsigned type on fluid_synth_set_reverb_preset(), fixed error on fluid_return_val_if_fail() usage. 2017-10-21 17:13:02 +02:00
carlo-bramini
b15f6c4b2a Reverted change to unsigned type on fluid_synth_set_reverb_preset(), used fluid_return_val_if_fail() for consistency. 2017-10-21 16:49:07 +02:00
carlo-bramini
ae041fdcec Made fluid_gen_info[] static 2017-10-21 16:41:03 +02:00
Marcus Weseloh
885178ef9d Replace timeout in deactivate with mutex and cond. 2017-10-21 16:32:04 +02:00
Marcus Weseloh
5f488123d8 Also make node names case-insensitive and update comments to reflect this. 2017-10-21 15:58:22 +02:00
Marcus Weseloh
cecf115a38 Replace the fuzzy prefix matching by a simple strncasecmp.
That spaces and underscores are treated as equal is no needed anymore
anyway, as the token parser of the shell understands quoted names.
So searching for "Dry / Wet Mix" is possible.

Adds new FLUID_STRNCASECMP macro to fluid_priv.
2017-10-21 15:55:43 +02:00
Marcus Weseloh
e05f1904d5 Update the LADSPA sample rate if the rvoice mixer sample rate changes. 2017-10-21 15:08:04 +02:00
Marcus Weseloh
2c7e1696fd Completely decouple LADSPA engine from FluidSynth
Knowledge of FluidSynth is completely removed from the LADSPA effects
unit. All synchronization happens inside LADSPA with atomic operations.
The LADSPA fx instance created by FluidSynth is only special in that
FluidSynth knows about it and calls it's run method when enabled.

This simplifies the code structure, makes the FluidSynth and the LADSPA
engine easier to maintain due to the loose coupling. It also enables
users to create their own (or additional) LADSPA fx unit for further
processing as soon as we expose the LADSPA functions via a public API.
2017-10-21 15:07:39 +02:00
Marcus Weseloh
812ea57ed0 Bugfix: properly release the LADSPA API lock after exiting fluid_ladspa_check 2017-10-21 15:03:38 +02:00