Commit Graph

926 Commits

Author SHA1 Message Date
derselbst 27f2ed3750 avoid redundant zero checking
count will never become 0
2017-10-25 10:42:59 +02:00
carlo-bramini 36f0ecb12a MSVC6 is the latest version not supporting deprecated declpec 2017-10-24 20:31:56 +02:00
carlo-bramini 96f0f5fe88 Use _close() on _WIN32 2017-10-24 20:25:58 +02:00
carlo-bramini 6068c20728 Place again list_of_generators_to_initialize[] inside fluid_voice_calculate_runtime_synthesis_parameters() 2017-10-24 20:23:21 +02:00
Marcus Weseloh e485129705 Merge pull request #249 from mawe42/more-ladspa-cleanup
More LADSPA cleanup and refactor
2017-10-24 15:50:05 +02:00
Marcus Weseloh dab11fd503 Breakup very long fluid_ladspa_check into smaller functions 2017-10-24 00:40:09 +02:00
Marcus Weseloh ab26f85bf8 Add check for in-place broken plugins
In-place broken plugins can't cope with input and output audio
ports connected to the same buffer.
2017-10-23 23:16:06 +02:00
Marcus Weseloh 8814926857 Replace number of inputs and outputs on ports with pointer to connected node
Ports can only have a single input or output, so no need for two counters.
And keeping track of the connected node means we can check for
INPLACE_BROKEN plugins, if multiple ports connect to the same node.
2017-10-23 22:12:04 +02:00
Marcus Weseloh 93dbac3535 When clearing LADSPA, also reset connection counts on system nodes 2017-10-23 22:07:58 +02:00
Marcus Weseloh f1cf28b00c Remove obsolete check for ladspa->state in rvoice mixer
The decision if plugins can be run should stay in the LADSPA codebase.
2017-10-23 21:41:28 +02:00
Marcus Weseloh a1ff8d0e55 Render all block using a single LADSPA run
Removes the need for VLAs before ladspa call in rvoice mixer and number
for for loops to set up and advance the buffers. Also reduces the number
of state changes (and atomic operations) by calling fluid_ladspa_run only
once.
2017-10-23 21:41:28 +02:00
Marcus Weseloh 105d9835cb Explicity pass in the audio buffer size when creating LADSPA fx.
And don't pass in node buffer sizes into new_fluid_ladspa_node but
determine it from the node type.
2017-10-23 21:41:20 +02:00
derselbst 168274fbbd fix build 2017-10-23 12:43:07 +02:00
Tom M b38d40013a Merge pull request #247 from rmattes/master
Fixed dumptuning. Fixes #246
2017-10-23 12:32:26 +02:00
R. Mattes afe915dab2 Fixed dumptuning 2017-10-22 21:36:25 +02:00
carlo-bramini 7db133acae 'mod_count' of struct fluid_voice_t should be an unsigned type. 2017-10-22 19:40:14 +02:00
Tom M 0689841e1f Merge pull request #243 from rmattes/master
Fixed nasty loop test. Fixes #244
2017-10-22 19:33:48 +02:00
carlo-bramini 9d49d29aaf Declare list_of_generators_to_initialize[] as global static const. 2017-10-22 19:19:14 +02:00
carlo-bramini e1c3b46ee2 Fix an handle leak 2017-10-22 19:13:16 +02:00
carlo-bramini 9be61b5cd4 'deprecated' is not supported on MSVC6. 2017-10-22 19:10:41 +02:00
R. Mattes 38758c78dd Fixed nasty loop test 2017-10-22 18:47:00 +02:00
derselbst 36d8f95584 avoid accessing uninited memory 2017-10-22 16:19:04 +02:00
derselbst 2623f67865 correctly fix use-after-free 2017-10-22 15:00:51 +02:00
derselbst a54dfa522a remove G_STMT_[START|END]
for readability
2017-10-22 14:45:16 +02:00
derselbst 77ad959913 remove unused fluid_debug() 2017-10-22 14:43:35 +02:00
derselbst 02bb14243a remove unused debug enum 2017-10-22 14:41:00 +02:00
derselbst 3d7465a01e remove FLUID_STMT_[START|END]
for readability
2017-10-22 14:39:06 +02:00
derselbst 2deffc40c0 remove redundant #ifdef LADSPA
cmake will take care of compiling fluid_ladspa.c
2017-10-22 14:31:57 +02:00
derselbst 456b6afa97 remove redundant getopt.h declarations 2017-10-22 13:25:25 +02:00
Marcus Weseloh 799f3ea44c Merge pull request #242 from mawe42/ladspa-additional-fixes
More fixes to LADSPA system
2017-10-22 11:38:37 +02:00
Marcus Weseloh e18e54d7ae White-space 2017-10-22 11:24:25 +02:00
Marcus Weseloh e0dcdbcdfc Correct documentation for fluid_ladspa_run 2017-10-22 11:24:25 +02:00
Marcus Weseloh 47d640571b Add missing check for ladspa_is_active to ladsap_control_defaults 2017-10-22 11:24:25 +02:00
Marcus Weseloh 29a4abb9a5 Use int for number of inputs and outputs, some plugins have a lot of ports 2017-10-22 11:24:25 +02:00
derselbst 24614d343d Revert "ladspa: atomically get and set pending_deactivation"
This reverts commit 6c69b8ccff.
2017-10-22 11:23:34 +02:00
Tom M 7146ecd61b Merge pull request #239 from carlo-bramini/fluidsynth_no_glib_1
Fluidsynth no glib 1
2017-10-22 08:47:56 +02:00
Tom M de617dd1f3 Merge pull request #240 from mawe42/ladspa-port-defaults
Add support for LADSPA control port defaults
2017-10-22 08:41:36 +02:00
Marcus Weseloh 8aa2d14476 Nicer error message when user requests LADSPA but is not available. 2017-10-21 22:40:19 +02:00
Marcus Weseloh 3cc684e47e Avoid a few ifdefs by defining two separate sets of node<->buffer functions 2017-10-21 22:36:34 +02:00
Marcus Weseloh 4d256ce8cc Add new command to FluidSynth shell to set control ports to default value 2017-10-21 19:49:49 +02:00
Marcus Weseloh 2787b0e10e Add function to automatically set unconnected port to default value
Uses the hints in the plugin to determine the default value.
2017-10-21 19:47:03 +02:00
Marcus Weseloh 7534e54d4f Check LADSPA setup before activation 2017-10-21 19:47:03 +02:00
carlo-bramini 828fdb9744 Completely remove G_STMT_* macros 2017-10-21 19:46:32 +02:00
derselbst 3486bb515b avoid null deref in jack driver 2017-10-21 19:30:09 +02:00
derselbst c205e0162d avoid null dereferences in delete_fluid_ladspa_plugin()
be extremely paranoid as suggested by clang-tidy
2017-10-21 19:01:07 +02:00
carlo-bramini 6f7ec3b1fc Added FLUID_STMT_START and FLUID_STMT_END 2017-10-21 18:40:57 +02:00
carlo-bramini 031c3671da Replace GPOINTER_TO_INT with FLUID_POINTER_TO_INT 2017-10-21 18:33:27 +02:00
carlo-bramini 122b249e27 Replace G_INT_TO_POINTER with FLUID_INT_TO_POINTER 2017-10-21 18:32:17 +02:00
derselbst 6c69b8ccff ladspa: atomically get and set pending_deactivation 2017-10-21 18:31:20 +02:00
carlo-bramini 82454b9fd5 Remove useless code, it's identical for both LE & BE 2017-10-21 18:29:18 +02:00