zdoom/fluidsynth
0
0
Fork 0
mirror of https://github.com/ZDoom/fluidsynth.git synced 2024-11-10 15:01:40 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add check for in-place broken plugins

Browse source 
In-place broken plugins can't cope with input and output audio
ports connected to the same buffer.
This commit is contained in:
Marcus Weseloh 2017-10-23 23:16:06 +02:00
parent 8814926857
commit ab26f85bf8
1 changed files with 37 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
src/bindings/fluid_ladspa.c
View file

@ -854,10 +854,11 @@ int fluid_ladspa_control_defaults(fluid_ladspa_fx_t *fx)
int fluid_ladspa_check(fluid_ladspa_fx_t *fx, char *err, int err_size)
{
int i;
unsigned int k;
unsigned int j, k;
int has_connections;
int num_system_nodes;
fluid_ladspa_plugin_t *plugin;
LADSPA_PortDescriptor flags1, flags2;
LADSPA_API_ENTER(fx);
@ -884,6 +885,41 @@ int fluid_ladspa_check(fluid_ladspa_fx_t *fx, char *err, int err_size)
}
}
/* In-place broken plugins can't cope with input and output audio ports connected to the same
* buffer. Check all plugins to make sure this doesn't happen */
for (i = 0; i < fx->num_plugins; i++)
{
plugin = fx->plugins[i];
if (!LADSPA_IS_INPLACE_BROKEN(plugin->desc->Properties))
continue;
for (j = 0; j < plugin->desc->PortCount; j++)
{
flags1 = plugin->desc->PortDescriptors[j];
for (k = 0; k < plugin->desc->PortCount; k++)
{
flags2 = plugin->desc->PortDescriptors[k];
/* First two bits or port flags specify input (1) or output (2) direction */
if (j != k
&& plugin->port_nodes[j] == plugin->port_nodes[k]
&& (flags1 & 0x3) != (flags2 & 0x3) /* first two bits encode direction */
&& LADSPA_IS_PORT_AUDIO(flags1) && LADSPA_IS_PORT_AUDIO(flags2))
{
FLUID_SNPRINTF(err, err_size,
"Plugin '%s' is in-place broken, '%s' and '%s' are not allowed "
"to connect to the same node\n",
plugin->desc->Label,
plugin->desc->PortNames[j],
plugin->desc->PortNames[k]);
LADSPA_API_RETURN(fx, FLUID_FAILED);
}
}
}
}
/* Check that at least one system input is used */
has_connections = 0;
for (i = 0; i < 2 * (fx->audio_groups + fx->effects_channels); i++)