zdoom/fluidsynth
0
0
Fork 0
mirror of https://github.com/ZDoom/fluidsynth.git synced 2024-11-27 06:22:06 +00:00
Code Issues Projects Releases Packages Wiki Activity

Stop dsound properly. (#642)

Browse source 
Stopping `dsound `before stopping `audio thread` avoid dsound playing transient glitches between the time audio task is stopped and dsound will be released. These short trailing glitches are particularly audible when captured by a reverb connected on output.
This commit is contained in:
jjceresa 2020-04-30 19:51:24 +02:00 committed by GitHub
parent e2d435dad6
commit 791dac6736
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/drivers/fluid_dsound.c
View file

@ -306,7 +306,18 @@ void delete_fluid_dsound_audio_driver(fluid_audio_driver_t *d)
fluid_dsound_audio_driver_t *dev = (fluid_dsound_audio_driver_t *) d;
fluid_return_if_fail(dev != NULL);
/* wait till the audio thread exits */
/* First tell dsound to stop playing its buffer now.
Doing this before stopping audio thread avoid dsound playing transient
glitches between the time audio task is stopped and dsound will be released.
These glitches are particularly audible when a reverb is connected
on output.
*/
if(dev->sec_buffer != NULL)
{
IDirectSoundBuffer_Stop(dev->sec_buffer);
}
/* request the audio task to stop and wait till the audio thread exits */
if(dev->thread != NULL)
{
/* tell the audio thread to stop its loop */
@ -329,11 +340,10 @@ void delete_fluid_dsound_audio_driver(fluid_audio_driver_t *d)
CloseHandle(dev->quit_ev);
}
/* release all the allocated resources */
/* Finish to release all the dsound allocated resources */
if(dev->sec_buffer != NULL)
{
IDirectSoundBuffer_Stop(dev->sec_buffer);
IDirectSoundBuffer_Release(dev->sec_buffer);
}