zdoom/fluidsynth
0
0
Fork 0
mirror of https://github.com/ZDoom/fluidsynth.git synced 2025-04-22 15:42:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix heap-use-after free

Browse source
This commit is contained in:
derselbst 2021-01-02 14:53:34 +01:00 committed by Tom M
parent 03cf8e28f6
commit 57f40ea91c
2 changed files with 47 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/midi/fluid_midi.c
View file

@ -1717,6 +1717,9 @@ delete_fluid_player(fluid_player_t *player)
fluid_return_if_fail(player != NULL);
fluid_settings_callback_int(player->synth->settings, "player.reset-synth",
NULL, NULL);
fluid_player_stop(player);
fluid_player_reset(player);

44
src/synth/fluid_synth.c
View file

@ -1006,6 +1006,50 @@ delete_fluid_synth(fluid_synth_t *synth)
fluid_profiling_print();
/* unregister all real-time settings callback, to avoid a use-after-free when changing those settings after
* this synth has been deleted*/
fluid_settings_callback_num(synth->settings, "synth.gain",
NULL, NULL);
fluid_settings_callback_int(synth->settings, "synth.polyphony",
NULL, NULL);
fluid_settings_callback_int(synth->settings, "synth.device-id",
NULL, NULL);
fluid_settings_callback_num(synth->settings, "synth.overflow.percussion",
NULL, NULL);
fluid_settings_callback_num(synth->settings, "synth.overflow.sustained",
NULL, NULL);
fluid_settings_callback_num(synth->settings, "synth.overflow.released",
NULL, NULL);
fluid_settings_callback_num(synth->settings, "synth.overflow.age",
NULL, NULL);
fluid_settings_callback_num(synth->settings, "synth.overflow.volume",
NULL, NULL);
fluid_settings_callback_num(synth->settings, "synth.overflow.important",
NULL, NULL);
fluid_settings_callback_str(synth->settings, "synth.overflow.important-channels",
NULL, NULL);
fluid_settings_callback_num(synth->settings, "synth.reverb.room-size",
NULL, NULL);
fluid_settings_callback_num(synth->settings, "synth.reverb.damp",
NULL, NULL);
fluid_settings_callback_num(synth->settings, "synth.reverb.width",
NULL, NULL);
fluid_settings_callback_num(synth->settings, "synth.reverb.level",
NULL, NULL);
fluid_settings_callback_int(synth->settings, "synth.reverb.active",
NULL, NULL);
fluid_settings_callback_int(synth->settings, "synth.chorus.active",
NULL, NULL);
fluid_settings_callback_int(synth->settings, "synth.chorus.nr",
NULL, NULL);
fluid_settings_callback_num(synth->settings, "synth.chorus.level",
NULL, NULL);
fluid_settings_callback_num(synth->settings, "synth.chorus.depth",
NULL, NULL);
fluid_settings_callback_num(synth->settings, "synth.chorus.speed",
NULL, NULL);
/* turn off all voices, needed to unload SoundFont data */
if(synth->voice != NULL)
{