zdoom/fluidsynth
0
0
Fork 0
mirror of https://github.com/ZDoom/fluidsynth.git synced 2024-11-13 08:07:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

settings: avoid silent error hiding

Browse source 
fail if param out of range, addresses #225
This commit is contained in:
derselbst 2017-10-06 10:28:28 +02:00
parent 84fe779b98
commit 3a4385c7f6
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/utils/fluid_settings.c
View file

@ -1098,8 +1098,11 @@ fluid_settings_setnum(fluid_settings_t* settings, const char *name, double val)
if (node->type == FLUID_NUM_TYPE) { if (node->type == FLUID_NUM_TYPE) {
fluid_num_setting_t* setting = &node->num; fluid_num_setting_t* setting = &node->num;
if (val < setting->min) val = setting->min; if (val < setting->min || val > setting->max)
else if (val > setting->max) val = setting->max; {
FLUID_LOG(FLUID_DBG, "requested set value for %s out of range", name);
return retval;
}
setting->value = val; setting->value = val;
@ -1247,8 +1250,11 @@ fluid_settings_setint(fluid_settings_t* settings, const char *name, int val)
if (node->type == FLUID_INT_TYPE) { if (node->type == FLUID_INT_TYPE) {
fluid_int_setting_t* setting = &node->i; fluid_int_setting_t* setting = &node->i;
if (val < setting->min) val = setting->min; if (val < setting->min || val > setting->max)
else if (val > setting->max) val = setting->max; {
FLUID_LOG(FLUID_DBG, "requested set value for %s out of range", name);
return retval;
}
setting->value = val; setting->value = val;