zdoom/acc
0
0
Fork 0
mirror of https://github.com/ZDoom/acc.git synced 2024-11-15 00:41:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix constant < > <= >= evaluation

Browse source 
- SendExprCommand() evaluated all four of these as their inverse. I
  wouldn't at all be surprised if this was caused by me fixing the
  undefined behavior (Which PopExStk() is called first?) and not
  even noticing that these were reversed because they popped off the stack
  in reverse order.
This commit is contained in:
Randy Heit 2014-02-04 20:21:51 -06:00
parent 3a5bedf702
commit 26d4df32d4
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
parse.c
View file

@ -3806,19 +3806,19 @@ static void SendExprCommand(pcd_t pcd)
break;
case PCD_LT:
operand2 = PopExStk();
PushExStk(PopExStk() >= operand2);
PushExStk(PopExStk() < operand2);
break;
case PCD_GT:
operand2 = PopExStk();
PushExStk(PopExStk() <= operand2);
PushExStk(PopExStk() > operand2);
break;
case PCD_LE:
operand2 = PopExStk();
PushExStk(PopExStk() > operand2);
PushExStk(PopExStk() <= operand2);
break;
case PCD_GE:
operand2 = PopExStk();
PushExStk(PopExStk() < operand2);
PushExStk(PopExStk() >= operand2);
break;
case PCD_ANDLOGICAL:
operand2 = PopExStk();