From f63b5914f6b14e4e4f1f4bda648b7c53eb6fbbb4 Mon Sep 17 00:00:00 2001
From: apartfromtime <42292382+apartfromtime@users.noreply.github.com>
Date: Sat, 10 Sep 2022 09:05:36 +1000
Subject: [PATCH] Include guard pointers

Spincontrol checks for null itemnames, which could cause undefined behaviour (menu disappears or crashes) in some instances.
---
 src/client/menu/menu.c | 42 ++++++++++++++----------------------------
 1 file changed, 14 insertions(+), 28 deletions(-)

diff --git a/src/client/menu/menu.c b/src/client/menu/menu.c
index be358185..b060df41 100644
--- a/src/client/menu/menu.c
+++ b/src/client/menu/menu.c
@@ -5228,7 +5228,6 @@ PlayerDirectoryList(void)
     char* findname = "players/*";
     char** list = 0;
     int num = 0;
-    int n = 0;
 
     // get a list of "players" subdirectories
     if ((list = FS_ListFiles2(findname, &num, 0, 0)) == 0)
@@ -5236,35 +5235,20 @@ PlayerDirectoryList(void)
         return false;
     }
 
-    n = num;
-
-    if (n > MAX_PLAYERMODELS)
+    if (num > MAX_PLAYERMODELS)
     {
-        n = MAX_PLAYERMODELS - 1;
-    }
-    
-    s_directory.num = 0;
-
-    for (int i = 0; i < n; ++i)
-    {
-        // last element of FS_FileList maybe null
-        if (list[i] == 0)
-        {
-            break;
-        }
-
-        s_directory.num++;
+        num = MAX_PLAYERMODELS - 1;
     }
 
     // malloc directories
-    char** data = (char**)malloc(s_directory.num * sizeof(char*));
-    YQ2_COM_CHECK_OOM(data, "malloc()", s_directory.num * sizeof(char*))
-    memset(data, 0, s_directory.num * sizeof(char*));
+    char** data = (char**)malloc(num * sizeof(char*));
+    YQ2_COM_CHECK_OOM(data, "malloc()", num * sizeof(char*))
+    memset(data, 0, num * sizeof(char*));
 
     s_directory.data = data;
-    s_directory.num = 0;
+    s_directory.num = num;
 
-    for (int i = 0; i < n; ++i)
+    for (int i = 0; i < num; ++i)
     {
         // last element of FS_FileList maybe null
         if (list[i] == 0)
@@ -5282,14 +5266,14 @@ PlayerDirectoryList(void)
         strncpy(s, t, MAX_QPATH - 1);         // MAX_QPATH - 1, gcc warns about truncation
         s[strlen(s)] = 0;
 
-        data[s_directory.num++] = s;
+        data[i] = s;
     }
     
     // free file list
     FS_FreeList(list, num);
 
     // sort them male, female, alphabetical
-    qsort(s_directory.data, s_directory.num, sizeof(char**), dircmp_func);
+    qsort(s_directory.data, s_directory.num - 1, sizeof(char**), dircmp_func);
 
     return true;
 }
@@ -5369,9 +5353,9 @@ PlayerModelList(void)
         }
 
         // malloc skinnames
-        data = (char**)malloc(s_skinnames[mdl].num * sizeof(char*));
-        YQ2_COM_CHECK_OOM(data, "malloc()", s_skinnames[mdl].num * sizeof(char*))
-        memset(data, 0, s_skinnames[mdl].num * sizeof(char*));
+        data = (char**)malloc((s_skinnames[mdl].num + 1) * sizeof(char*));
+        YQ2_COM_CHECK_OOM(data, "malloc()", (s_skinnames[mdl].num + 1) * sizeof(char*))
+        memset(data, 0, (s_skinnames[mdl].num + 1) * sizeof(char*));
         
         s_skinnames[mdl].data = data;
         s_skinnames[mdl].num = 0;
@@ -5406,6 +5390,8 @@ PlayerModelList(void)
             }
         }
 
+        s_skinnames[mdl].num++;         // guard pointer
+
         // at this point we have a valid player model
         s = (char*)malloc(MAX_DISPLAYNAME);
         t = strrchr(s_directory.data[i], '/');