yquake2/yquake2remaster
0
0
Fork 0
mirror of https://github.com/yquake2/yquake2remaster.git synced 2025-02-20 19:02:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

Implement a better hack for warping surfaces regarding lightning.

Browse source 
The old hack was sufficient for classic rendering, but break with
gl_overbrightbits enabled. See the inline comment for details.
This commit is contained in:
Yamagi Burmeister 2016-08-12 20:28:21 +02:00
parent d6136cbba5
commit f16928f2cf
1 changed files with 24 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/client/refresh/r_surf.c
View file

@ -443,10 +443,30 @@ R_RenderBrushPoly(msurface_t *fa)
{ {
R_Bind(image->texnum); R_Bind(image->texnum);
/* warp texture, no lightmaps */ /* This is a hack ontop of a hack. Warping surfaces like those generated
R_TexEnv(GL_MODULATE); by R_EmitWaterPolys() don't have a lightmap. Original Quake II therefor
glColor4f(gl_state.inverse_intensity, gl_state.inverse_intensity, negated the global intensity on those surfaces, because otherwise they
gl_state.inverse_intensity, 1.0f); would show up much too bright. When we implemented overbright bits this
hack modified the global GL state in an incompatible way. So implement
a new hack, based on overbright bits... Depending on the value set to
gl_overbrightbits the result is different:
0: Old behaviour.
1: No overbright bits on the global scene but correct lightning on
warping surfaces. */
if (gl_overbrightbits->value)
{
R_TexEnv(GL_COMBINE_EXT);
R_SelectTexture(GL_TEXTURE1);
glTexEnvi(GL_TEXTURE_ENV, GL_RGB_SCALE_EXT, gl_overbrightbits->value);
}
else
{
R_TexEnv(GL_MODULATE);
glColor4f(gl_state.inverse_intensity, gl_state.inverse_intensity,
gl_state.inverse_intensity, 1.0f);
}
R_EmitWaterPolys(fa); R_EmitWaterPolys(fa);
R_TexEnv(GL_REPLACE); R_TexEnv(GL_REPLACE);