yquake2/yquake2remaster
0
0
Fork 0
mirror of https://github.com/yquake2/yquake2remaster.git synced 2024-11-30 08:20:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cast arguments to ctype functions to unsigned char

Browse source 
According to the C standard, arguments to the ctype functions
must fit into unsigned char (presumably so they can be implemented
with simple array access). This causes a build time warning on
NetBSD, and may function incorrectly if any UTF-8 strings are used.
This commit is contained in:
nia 2020-11-24 14:12:38 +01:00
parent d419e1f660
commit 92e62e49d3
5 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/client/curl/download.c
View file

@ -127,7 +127,7 @@ static void CL_EscapeHTTPPath(const char *filePath, char *escaped)
for (int i = 0; i < len; i++)
{
if (!isalnum(filePath[i]) && filePath[i] != ';' && filePath[i] != '/' &&
if (!isalnum((unsigned char)filePath[i]) && filePath[i] != ';' && filePath[i] != '/' &&
filePath[i] != '?' && filePath[i] != ':' && filePath[i] != '@' && filePath[i] != '&' &&
filePath[i] != '=' && filePath[i] != '+' && filePath[i] != '$' && filePath[i] != ',' &&
filePath[i] != '[' && filePath[i] != ']' && filePath[i] != '-' && filePath[i] != '_' &&

2
src/client/menu/menu.c
View file

@ -3206,7 +3206,7 @@ StartServer_MenuInit(void)
for (j = 0; j < l; j++)
{
shortname[j] = toupper(shortname[j]);
shortname[j] = toupper((unsigned char)shortname[j]);
}
strcpy(longname, COM_Parse(&s));

2
src/client/refresh/gl1/gl1_main.c
View file

@ -969,7 +969,7 @@ R_RenderView(refdef_t *fd)
// Decode the colour name from its character.
for (eye = 0; eye < 2; ++eye) {
colour = 0;
switch (toupper(gl1_stereo_anaglyph_colors->string[eye])) {
switch (toupper((unsigned char)gl1_stereo_anaglyph_colors->string[eye])) {
case 'B': ++colour; // 001 Blue
case 'G': ++colour; // 010 Green
case 'C': ++colour; // 011 Cyan

2
src/common/cmdparser.c
View file

@ -971,7 +971,7 @@ Cmd_CompleteMapCommand(char *partial)
{
for (k = 1; k < nbMatches; k++)
{
if (j >= strlen(pmatch[k]) || tolower(pmatch[0][j]) != tolower(pmatch[k][j]))
if (j >= strlen(pmatch[k]) || tolower((unsigned char)pmatch[0][j]) != tolower((unsigned char)pmatch[k][j]))
{
partialFillContinue = false;
break;

2
src/common/shared/shared.c
View file

@ -1104,7 +1104,7 @@ Q_strlwr ( char *s )
while ( *s )
{
*s = tolower( *s );
*s = tolower( (unsigned char)*s );
s++;
}