yquake2/yquake2remaster
0
0
Fork 0
mirror of https://github.com/yquake2/yquake2remaster.git synced 2025-02-16 17:11:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

Describe the limitiations of GLimp_GetRefreshRate().

Browse source
This commit is contained in:
Yamagi Burmeister 2018-11-06 12:23:25 +01:00
parent 8d5734ce9d
commit 3c21575a01
1 changed files with 18 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/client/vid/glimp_sdl.c
View file

@ -369,7 +369,22 @@ GLimp_GrabInput(qboolean grab)
}
/*
* Returns the current display refresh rate.
* Returns the current display refresh rate. There're 2 limitations:
*
* * The timing code in frame.c only understands full integers, so
* values given by vid_displayrefreshrate are always round up. For
* example 59.95 become 60. Rounding up is the better choice for
* most users because assuming a too high display refresh rate
* avoids micro stuttering caused by missed frames if the vsync
* is enabled. The price are small and hard to notice timing
* problems.
*
* * SDL returns only full integer. In most cases they're rounded
* up, but in some cases - likely depending on the GPU driver -
* they're rounded down. If the value is rounded up, we'll see
* some small and nard to notice timing problems. If the value
* is rounded down frames will be missed. Both is only relevant
* if the vsync is enabled.
*/
int
GLimp_GetRefreshRate(void)
@ -380,23 +395,20 @@ GLimp_GetRefreshRate(void)
glimp_refreshRate = ceil(vid_displayrefreshrate->value);
}
/* Do this only once. We asume that no one will change their
refresh rate or plug new display hardware in while the
game is running. */
if (glimp_refreshRate == -1)
{
SDL_DisplayMode mode;
int i = SDL_GetWindowDisplayIndex(window);
if(i >= 0 && SDL_GetCurrentDisplayMode(i, &mode) == 0)
if (i >= 0 && SDL_GetCurrentDisplayMode(i, &mode) == 0)
{
glimp_refreshRate = mode.refresh_rate;
}
// Something went wrong, use default.
if (glimp_refreshRate <= 0)
{
/* Apparently the stuff above failed, use default */
glimp_refreshRate = 60;
}
}