yquake2/yquake2remaster
0
0
Fork 0
mirror of https://github.com/yquake2/yquake2remaster.git synced 2024-11-10 15:21:44 +00:00
Code Issues Projects Releases Packages Wiki Activity

Limit the number of parallel downloads to just 1.

Browse source 
Since the moment I took a very first look at the download code I wasn't
a friend of parallel downloads. There're several reasons for that:

- Parallel downloading needs some ugly hacks. For example downloading a
  pak file has a high chance to make asset downloads running in parallel
  unnecessary.
- Parallel downloads are hard to debug.
- There's just no need for them. I've tested several connection, 1
  GBit/s LAN, 50 MBit/s DSL, 6 MBit/s DSL, and there wasn't a
  significant difference between 1, 4 or even 16 parallel downloads.

I'm leaving the parallel download code in place. I someone really wants
parallel downloads he can bump the MAX_HTTP_HANDLES define.
This commit is contained in:
Yamagi Burmeister 2018-12-21 15:05:31 +01:00
parent 7b200208c5
commit 2199b67a39
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/client/curl/header/download.h
View file

@ -30,7 +30,7 @@
#define DOWNLOAD_H
// Number of max. parallel downloads.
#define MAX_HTTP_HANDLES 16
#define MAX_HTTP_HANDLES 1
#include <curl/curl.h>
#include "../../../common/header/common.h"