Rewrite COM_FileExtention()

COM_FileExtension() was parsing strings from beginning to end, bailing
out as soon as '.' was found and treating everything thereafter as the
file extension. That behavior caused problem with relatives pathes like
models/monsters/tank/../ctank/skin.pcx. The new implementation uses
strrchr() to determine the last '.'.
This commit is contained in:
Yamagi Burmeister 2014-07-30 21:46:55 +02:00
parent 2e95fab925
commit dd50746c4c
2 changed files with 6 additions and 20 deletions

View file

@ -51,7 +51,7 @@ extern short BigShort ( short l ) ;
extern void COM_DefaultExtension ( char * path , const char * extension ) ;
extern void COM_FilePath ( const char * in , char * out ) ;
extern void COM_FileBase ( char * in , char * out ) ;
extern char * COM_FileExtension ( char * in ) ;
extern const char * COM_FileExtension ( const char * in ) ;
extern void COM_StripExtension ( char * in , char * out ) ;
extern char * COM_SkipPath ( char * pathname ) ;
extern int Q_log2 ( int val ) ;

View file

@ -650,31 +650,17 @@ COM_StripExtension(char *in, char *out)
*out = 0;
}
char *
COM_FileExtension(char *in)
const char *
COM_FileExtension(const char *in)
{
static char exten[8];
int i;
const char *ext = strrchr(in, '.');
while (*in && *in != '.')
{
in++;
}
if (!*in)
if (!ext || ext == in)
{
return "";
}
in++;
for (i = 0; i < 7 && *in; i++, in++)
{
exten[i] = *in;
}
exten[i] = 0;
return exten;
return ext + 1;
}
void