vera/nuclide
4
0
Fork 0
Code Issues 32 Pull requests Projects Releases Packages Activity

Remove ftebug_checkpvs(), undefined behaviour was causing things to pop

Browse source 
in and out of existence. There was no fault with FTE's implementation after
all. Change func_dustmotes, prop_rope and env_glow to querying player pos
more reliably.
This commit is contained in:
Marco Cawthorne 2021-06-29 10:47:51 +02:00
parent 2e8bb7e23c
commit 883a64b744
4 changed files with 16 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/gs-entbase/client/env_glow.qc
View file

@ -168,8 +168,8 @@ env_glow::env_glow(void)
m_vecColor = [1,1,1];
drawmask = MASK_ENGINE;
setsize(this, [0,0,0], [0,0,0]);
setorigin(this, origin);
effects &= ~EF_NOSHADOW;
Init();
RendererRestarted();
setorigin(this, origin);
}

10
src/gs-entbase/client/func_dustmotes.qc
View file

@ -38,10 +38,16 @@ class func_dustmotes:CBaseEntity
float
func_dustmotes::predraw(void)
{
if (m_flNexTime > cltime)
vector vecPlayer;
int s = (float)getproperty(VF_ACTIVESEAT);
pSeat = &g_seats[s];
vecPlayer = pSeat->m_vecPredictedOrigin;
if (checkpvs(vecPlayer, this) == FALSE)
return (PREDRAW_NEXT);
if (checkpvs(getproperty(VF_ORIGIN), this) == FALSE)
if (m_flNexTime > cltime)
return (PREDRAW_NEXT);
for (int i = 0; i < m_iCount; i++) {

9
src/gs-entbase/client/prop_rope.qc
View file

@ -115,11 +115,16 @@ prop_rope::predraw(void)
float travel;
float segments;
float sc;
vector vecPlayer;
entity x = find(world, ::targetname, target);
if (checkpvs(getproperty(VF_ORIGIN), this) == FALSE) {
if (checkpvs(getproperty(VF_ORIGIN), x) == FALSE) {
int s = (float)getproperty(VF_ACTIVESEAT);
pSeat = &g_seats[s];
vecPlayer = pSeat->m_vecPredictedOrigin;
if (checkpvs(vecPlayer, this) == FALSE) {
if (checkpvs(vecPlayer, x) == FALSE) {
return (PREDRAW_NEXT);
}
}

11
src/shared/defs.h
View file

@ -107,17 +107,6 @@ precache_model(string m)
return prior(m);
}
/* fun little hack for us engine bug lovers */
var int autocvar_ftebug_checkpvs = 1;
__wrap float
checkpvs(vector viewpos, entity ent)
{
if (autocvar_ftebug_checkpvs)
return 1;
else
return prior(viewpos, ent);
}
__wrap void
setmodel(entity ent, string mname)
{