From a8ce30163e6cbc17fc3e25b69fdd76a22ac45be8 Mon Sep 17 00:00:00 2001 From: /dev/humancontroller Date: Sun, 14 Apr 2013 18:33:25 +0200 Subject: [PATCH] make the fread() success-check code in Sys_RandomBytes() more secure --- code/sys/sys_unix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/sys/sys_unix.c b/code/sys/sys_unix.c index 7dfcd563..607d0f21 100644 --- a/code/sys/sys_unix.c +++ b/code/sys/sys_unix.c @@ -123,7 +123,7 @@ qboolean Sys_RandomBytes( byte *string, int len ) if( !fp ) return qfalse; - if( !fread( string, sizeof( byte ), len, fp ) ) + if( fread( string, sizeof( byte ), len, fp ) != len ) { fclose( fp ); return qfalse;