ubergames/gtkradiant
0
0
Fork 0
mirror of https://github.com/UberGames/GtkRadiant.git synced 2024-11-10 06:31:41 +00:00
Code Issues Projects Releases Packages Wiki Activity

q3map2: fix dangling pointer dereference

Browse source 
`last` was used but not initialized.

Also fixes a segmentation fault if PATH is not in the environment.
This commit is contained in:
Ben Noordhuis 2012-03-18 01:53:03 +01:00
parent d7e9dab03d
commit 808e1c9f6f
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
tools/quake3/q3map2/path_init.c
View file

@ -111,20 +111,16 @@ void LokiInitPaths( char *argv0 ){
home = "."; home = ".";
} }
path = getenv( "PATH" );
/* do some path divining */ /* do some path divining */
strcpy( temp, argv0 ); strcpy( temp, argv0 );
if ( strrchr( temp, '/' ) ) { if ( strrchr( temp, '/' ) ) {
argv0 = strrchr( argv0, '/' ) + 1; argv0 = strrchr( argv0, '/' ) + 1;
} }
else else if ( path ) {
{
/* get path environment variable */
path = getenv( "PATH" );
/* minor setup */
last[ 0 ] = path[ 0 ];
last[ 1 ] = '\0';
found = qfalse; found = qfalse;
last = path;
/* go through each : segment of path */ /* go through each : segment of path */
while ( last[ 0 ] != '\0' && found == qfalse ) while ( last[ 0 ] != '\0' && found == qfalse )