teambeef/raze
0
0
Fork 0
mirror of https://github.com/DrBeef/Raze.git synced 2024-11-15 00:41:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

- fixed OOB access in pushmove.

Browse source 
The backwards search loop starts at one element behind the data it is supposed to check. If this is the last wall in the map it accesses undefined memory.

This tripped the range check in TArray for wall[].
This commit is contained in:
Christoph Oelckers 2021-12-12 15:52:40 +01:00
parent 4562a0ca97
commit a23d2ae656
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
source/build/src/clip.cpp
View file

@ -868,7 +868,7 @@ int pushmove_(vec3_t *const vect, int *const sectnum,
if (dir > 0)
startwall = sec->wallptr, endwall = startwall + sec->wallnum;
else
endwall = sec->wallptr, startwall = endwall + sec->wallnum;
endwall = sec->wallptr - 1, startwall = endwall + sec->wallnum - 1;
int i;