From 7856d30957ae7b284ec70ca0d08a50e401177cd8 Mon Sep 17 00:00:00 2001
From: Dale Whinham <daleyo@gmail.com>
Date: Wed, 6 Jul 2022 02:09:03 +0100
Subject: [PATCH] Improve KDE/kdialog detection

If KDE is running but kdialog is not present on the system (e.g. as is
the case on SteamOS), allow falling back on the GTK dialogs instead.
---
 source/common/platform/posix/sdl/i_system.cpp | 24 +++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/source/common/platform/posix/sdl/i_system.cpp b/source/common/platform/posix/sdl/i_system.cpp
index bcc6aee51..a63b15a9f 100644
--- a/source/common/platform/posix/sdl/i_system.cpp
+++ b/source/common/platform/posix/sdl/i_system.cpp
@@ -85,6 +85,24 @@ void I_SetIWADInfo()
 {
 }
 
+static bool I_KDialogAvailable()
+{
+	// Is KDE running?
+	const char* str = getenv("KDE_FULL_SESSION");
+	if (str && strcmp(str, "true") == 0)
+	{
+		// Is kdialog available?
+		FILE* f = popen("which kdialog >/dev/null 2>&1", "r");
+		if (f != NULL)
+		{
+			int status = pclose(f);
+			return WIFEXITED(status) && WEXITSTATUS(status) == 0;
+		}
+	}
+
+	return false;
+}
+
 //
 // I_Error
 //
@@ -99,8 +117,7 @@ void Unix_I_FatalError(const char* errortext)
 	// Close window or exit fullscreen and release mouse capture
 	SDL_QuitSubSystem(SDL_INIT_VIDEO);
 
-	const char *str;
-	if((str=getenv("KDE_FULL_SESSION")) && strcmp(str, "true") == 0)
+	if(I_KDialogAvailable())
 	{
 		FString cmd;
 		cmd << "kdialog --title \"" GAMENAME " " << GetVersionString()
@@ -294,8 +311,7 @@ int I_PickIWad (WadStuff *wads, int numwads, bool showwin, int defaultiwad)
 	}
 
 #ifndef __APPLE__
-	const char *str;
-	if((str=getenv("KDE_FULL_SESSION")) && strcmp(str, "true") == 0)
+	if(I_KDialogAvailable())
 	{
 		FString cmd("kdialog --title \"" GAMENAME " ");
 		cmd << GetVersionString() << ": Select an IWAD to use\""