teambeef/raze
0
0
Fork 0
mirror of https://github.com/DrBeef/Raze.git synced 2025-02-21 03:01:36 +00:00
Code Issues Projects Releases Packages Wiki Activity

Revert "- did a few checks with the compatibility optioned slope adjustment and decided to enable it unconditionally."

Browse source 
This reverts commit 6636064d1f.

As it turned out this is not a benign change. It breaks accessibility to a key in RR-Route 66's slaughtr.map - and it's reasonable to assume if it breaks one map it may break others as well.
This commit is contained in:
Christoph Oelckers 2022-11-26 16:47:02 +01:00
parent 0e1121ed51
commit 229ee3dbe4
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
source/core/gamefuncs.cpp
View file

@ -29,7 +29,6 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
IntRect viewport3d;
constexpr double MAXCLIPDISTF = 64;
CVARD(Bool, strict_compatibility, false, CVAR_ARCHIVE | CVAR_GLOBALCONFIG, "Enables stricter compatibility checks in the backend code")
//---------------------------------------------------------------------------
//
@ -887,7 +886,7 @@ bool checkRangeOfWall(walltype* wal, EWallFlags flagmask, const DVector3& pos, d
if (BoxOnLineSide(boxtl, boxbr, pos1, pos2 - pos1) != -1) return false;
auto closest = pos.XY();
if (enginecompatibility_mode == ENGINECOMPATIBILITY_NONE || !strict_compatibility)
if (enginecompatibility_mode == ENGINECOMPATIBILITY_NONE) // todo: need to check if it makes sense to have this always on.
SquareDistToSector(closest.X, closest.Y, nextsect, &closest);
calcSlope(nextsect, closest.X, closest.Y, &theZs[0], &theZs[1]);
@ -985,7 +984,7 @@ void getzrange(const DVector3& pos, sectortype* sect, double* ceilz, CollisionBa
const ESpriteFlags dasprclipmask = ESpriteFlags::FromInt(cliptype >> 16);
auto closest = pos.XY();
if (enginecompatibility_mode == ENGINECOMPATIBILITY_NONE || !strict_compatibility)
if (enginecompatibility_mode == ENGINECOMPATIBILITY_NONE)
SquareDistToSector(closest.X, closest.Y, sect, &closest);
calcSlope(sect, closest, ceilz, florz);