mirror of
https://github.com/DrBeef/ioq3quest.git
synced 2024-11-11 15:21:40 +00:00
bc4ca164e0
really fix the confusion with game entity and refentity numbers
for any natural number M, the following is logical as a whole:
- the array size for refentities is M;
- the refentity number limit is M-1, ie., each refentity number is in [0..M-1];
- the special number for the world is M.
before r1429, the code was roughly the following:
// constants related to the game, should not be used by the renderer
// renderer stuff
refEntity_t refEntities[MAX_ENTITIES];
int numRefEntities = 0;
void addRefEntity(refEntity_t re)
{
if (numRefEntities >= ENTITYNUM_WORLD)
return; // full
refEntities[numRefEntities++] = re;
}
void render(int num)
{
if (num == ENTITYNUM_WORLD)
renderWorld();
else
renderRefEntity(refEntities[num]);
}
so before r1429,
- the array size for refentities was 1023;
- the refentity number limit was 1021, ie., each refentity number was in [0..1021]; and
- the special number for the world entity was 1022.
this was a small waste of memory, as the last array element wasn't used.
r1429 changed
if (numRefEntities >= ENTITYNUM_WORLD)
to
if (numRefEntities >= MAX_ENTITIES).
this creates the following configuration:
- the array size for refentities is 1023;
- the refentity number limit is 1022, ie., each refentity number is in [0..1022]; and
- the special number for the world entity is 1022.
r1429 just makes things worse: it allows 1 more refentity to be added, but that entity doesn't get drawn anyway, as its number will be equal to the special number for the world. this is a small waste of not only memory, but also processing time.
perhaps in XreaL,
ENTITYNUM_WORLD is a game entity constant, and has nothing to do with refentities. a new REFENTITYNUM_WORLD constant should be added to denote the special number for the world, and that constant should be used in the renderer code in place of ENTITYNUM_WORLD. so define such a constant, and let it be equal to MAX_ENTITIES, which is 1023.
|
||
|---|---|---|
| .. | ||
| iqm.h | ||
| qgl.h | ||
| tr_animation.c | ||
| tr_backend.c | ||
| tr_bsp.c | ||
| tr_cmds.c | ||
| tr_curve.c | ||
| tr_flares.c | ||
| tr_font.c | ||
| tr_image.c | ||
| tr_image_bmp.c | ||
| tr_image_jpg.c | ||
| tr_image_pcx.c | ||
| tr_image_png.c | ||
| tr_image_tga.c | ||
| tr_init.c | ||
| tr_light.c | ||
| tr_local.h | ||
| tr_main.c | ||
| tr_marks.c | ||
| tr_mesh.c | ||
| tr_model.c | ||
| tr_model_iqm.c | ||
| tr_noise.c | ||
| tr_public.h | ||
| tr_scene.c | ||
| tr_shade.c | ||
| tr_shade_calc.c | ||
| tr_shader.c | ||
| tr_shadows.c | ||
| tr_sky.c | ||
| tr_subs.c | ||
| tr_surface.c | ||
| tr_types.h | ||
| tr_world.c | ||