teambeef/ioq3quest
0
0
Fork 0
mirror of https://github.com/DrBeef/ioq3quest.git synced 2024-11-22 20:11:40 +00:00
Code Issues Projects Releases Packages Wiki Activity

https://bugzilla.icculus.org/show_bug.cgi?id=2356

Browse source 
Remotely exploitable Infostring Crash
This commit is contained in:
Zachary Slater 2005-09-01 02:13:47 +00:00
parent b0b8e0114b
commit 01da6d757b
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
code/server/sv_main.c
View file

@ -373,6 +373,15 @@ void SVC_Info( netadr_t from ) {
return;
}
/*
* Check whether Cmd_Argv(1) has a sane length. This was not done in the original Quake3 version which led
* to the Infostring bug discovered by Luigi Auriemma. See http://aluigi.altervista.org/ for the advisory.
*/
// A maximum challenge length of 128 should be more than plenty.
if(strlen(Cmd_Argv(1)) > 128)
return;
// don't count privateclients
count = 0;
for ( i = sv_privateClients->integer ; i < sv_maxclients->integer ; i++ ) {