Fixed an issue where thing positions were modified even when the new position was the same as the old one. Fixes #644

This commit is contained in:
biwa 2021-10-25 00:32:10 +02:00 committed by spherallic
parent 22dfd69bbf
commit b48806838d
1 changed files with 23 additions and 21 deletions

View File

@ -417,39 +417,41 @@ namespace CodeImp.DoomBuilder.Map
// NOTE: This does not update sector! (call DetermineSector)
public void Move(Vector3D newpos)
{
BeforePropsChange();
if (newpos != pos)
{
BeforePropsChange();
// Change position
this.pos = newpos;
// Change position
this.pos = newpos;
if(SRB2Type != General.Map.Config.Start3DModeThingType)
General.Map.IsChanged = true;
if (SRB2Type != General.Map.Config.Start3DModeThingType)
General.Map.IsChanged = true;
}
}
// This moves the thing
// NOTE: This does not update sector! (call DetermineSector)
public void Move(Vector2D newpos)
{
BeforePropsChange();
Vector3D p = new Vector3D(newpos.x, newpos.y, pos.z);
// Change position
this.pos = new Vector3D(newpos.x, newpos.y, pos.z);
if (p != pos)
{
BeforePropsChange();
if(SRB2Type != General.Map.Config.Start3DModeThingType)
General.Map.IsChanged = true;
// Change position
this.pos = p;
if (SRB2Type != General.Map.Config.Start3DModeThingType)
General.Map.IsChanged = true;
}
}
// This moves the thing
// NOTE: This does not update sector! (call DetermineSector)
public void Move(float x, float y, float zoffset)
{
BeforePropsChange();
// Change position
this.pos = new Vector3D(x, y, zoffset);
if(SRB2Type != General.Map.Config.Start3DModeThingType)
General.Map.IsChanged = true;
Move(new Vector3D(x, y, zoffset));
}
// This rotates the thing