stjr/UltimateZoneBuilder
0
0
Fork 0
mirror of https://git.do.srb2.org/STJr/UltimateZoneBuilder.git synced 2024-11-23 04:12:12 +00:00
Code Issues Projects Releases Packages Wiki Activity

Map Analysis mode: "Check overlapping vertices" returned false-positive results in some cases.

Browse source 
Map Analysis mode: fixed a couple of minor glitches related to enabling/disabling results list, "fix" buttons and "fix all" checkbox.
This commit is contained in:
MaxED 2014-09-12 21:36:52 +00:00
parent 99f6a9a5a8
commit cf82e5e10d
3 changed files with 15 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Source/Plugins/BuilderModes/BuilderModes.csproj
View file

@ -531,6 +531,9 @@
<ItemGroup>
<None Include="Resources\Show2.png" />
</ItemGroup>
<ItemGroup>
<None Include="Resources\HideAll.png" />
</ItemGroup>
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Other similar extension points exist, see Microsoft.Common.targets.

2
Source/Plugins/BuilderModes/ErrorChecks/CheckOverlappingVertices.cs
View file

@ -44,7 +44,7 @@ namespace CodeImp.DoomBuilder.BuilderModes
// Go for all the linedefs that our vertex could overlap
foreach(Linedef l in block.Lines) {
if(v == l.Start || v == l.End) continue;
if((float)Math.Round(l.Line.GetDistanceToLine(v.Position, true), General.Map.FormatInterface.VertexDecimals) == 0) {
if((float)Math.Round(l.Line.GetDistanceToLine(v.Position, true), 3) == 0) {
SubmitResult(new ResultVertexOverlappingLine(v, l));
}
}

14
Source/Plugins/BuilderModes/Interface/ErrorCheckForm.cs
View file

@ -201,12 +201,13 @@ namespace CodeImp.DoomBuilder.BuilderModes
blockmap = null;
// When no results found, show "no results" and disable the list
if(results.Items.Count == 0) {
if(resultslist.Count == 0) {
results.Items.Add(new ResultNoErrors());
results.Enabled = false;
exportresults.Enabled = false; //mxd
} else {
exportresults.Enabled = true; //mxd
ClearSelectedResult(); //mxd
}
}
}
@ -270,9 +271,7 @@ namespace CodeImp.DoomBuilder.BuilderModes
}
ClearSelectedResult();
//mxd
applyToAll = cbApplyToAll.Checked;
applyToAll = cbApplyToAll.Checked; //mxd
this.Hide();
}
@ -281,6 +280,9 @@ namespace CodeImp.DoomBuilder.BuilderModes
private void ClearSelectedResult()
{
results.SelectedIndex = -1;
if (results.Items.Count == 0 && resultslist.Count > 0) //mxd
resultinfo.Text = "All results are hidden. Use context menu to show them.";
else
resultinfo.Text = "Select a result from the list to see more information.\r\nRight-click on a result to show context menu.";
resultinfo.Enabled = false;
fix1.Visible = false;
@ -621,6 +623,7 @@ namespace CodeImp.DoomBuilder.BuilderModes
// Do the obvious
UpdateTitle();
ClearSelectedResult();
}
private void resulthidecurrent_Click(object sender, EventArgs e)
@ -632,6 +635,7 @@ namespace CodeImp.DoomBuilder.BuilderModes
// Do the obvious
UpdateTitle();
ClearSelectedResult();
}
private void resulthidecurrenttype_Click(object sender, EventArgs e)
@ -654,6 +658,7 @@ namespace CodeImp.DoomBuilder.BuilderModes
// Do the obvious
UpdateTitle();
ClearSelectedResult();
}
private void resultshowonlycurrent_Click(object sender, EventArgs e)
@ -684,6 +689,7 @@ namespace CodeImp.DoomBuilder.BuilderModes
// Do the obvious
UpdateTitle();
ClearSelectedResult();
}
private void resultcopytoclipboard_Click(object sender, EventArgs e)