From cf82e5e10d4b8a55621adc3b88f01c215b43d79a Mon Sep 17 00:00:00 2001
From: MaxED <j.maxed@gmail.com>
Date: Fri, 12 Sep 2014 21:36:52 +0000
Subject: [PATCH] Map Analysis mode: "Check overlapping vertices" returned
 false-positive results in some cases. Map Analysis mode: fixed a couple of
 minor glitches related to enabling/disabling results list, "fix" buttons and
 "fix all" checkbox.

---
 Source/Plugins/BuilderModes/BuilderModes.csproj  |  3 +++
 .../ErrorChecks/CheckOverlappingVertices.cs      |  2 +-
 .../BuilderModes/Interface/ErrorCheckForm.cs     | 16 +++++++++++-----
 3 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/Source/Plugins/BuilderModes/BuilderModes.csproj b/Source/Plugins/BuilderModes/BuilderModes.csproj
index 1bd07eee..8ee38227 100644
--- a/Source/Plugins/BuilderModes/BuilderModes.csproj
+++ b/Source/Plugins/BuilderModes/BuilderModes.csproj
@@ -531,6 +531,9 @@
   <ItemGroup>
     <None Include="Resources\Show2.png" />
   </ItemGroup>
+  <ItemGroup>
+    <None Include="Resources\HideAll.png" />
+  </ItemGroup>
   <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.
diff --git a/Source/Plugins/BuilderModes/ErrorChecks/CheckOverlappingVertices.cs b/Source/Plugins/BuilderModes/ErrorChecks/CheckOverlappingVertices.cs
index cad951dd..1736532f 100644
--- a/Source/Plugins/BuilderModes/ErrorChecks/CheckOverlappingVertices.cs
+++ b/Source/Plugins/BuilderModes/ErrorChecks/CheckOverlappingVertices.cs
@@ -44,7 +44,7 @@ namespace CodeImp.DoomBuilder.BuilderModes
 				// Go for all the linedefs that our vertex could overlap
 				foreach(Linedef l in block.Lines) {
 					if(v == l.Start || v == l.End) continue;
-					if((float)Math.Round(l.Line.GetDistanceToLine(v.Position, true), General.Map.FormatInterface.VertexDecimals) == 0) {
+					if((float)Math.Round(l.Line.GetDistanceToLine(v.Position, true), 3) == 0) {
 						SubmitResult(new ResultVertexOverlappingLine(v, l));
 					}
 				}
diff --git a/Source/Plugins/BuilderModes/Interface/ErrorCheckForm.cs b/Source/Plugins/BuilderModes/Interface/ErrorCheckForm.cs
index d5115ca9..e26cad9c 100644
--- a/Source/Plugins/BuilderModes/Interface/ErrorCheckForm.cs
+++ b/Source/Plugins/BuilderModes/Interface/ErrorCheckForm.cs
@@ -201,12 +201,13 @@ namespace CodeImp.DoomBuilder.BuilderModes
 				blockmap = null;
 				
 				// When no results found, show "no results" and disable the list
-				if(results.Items.Count == 0) {
+				if(resultslist.Count == 0) {
 					results.Items.Add(new ResultNoErrors());
 					results.Enabled = false;
 					exportresults.Enabled = false; //mxd
 				} else { 
 					exportresults.Enabled = true; //mxd
+					ClearSelectedResult(); //mxd
 				}
 			}
 		}
@@ -270,9 +271,7 @@ namespace CodeImp.DoomBuilder.BuilderModes
 			}
 
 			ClearSelectedResult();
-
-			//mxd
-			applyToAll = cbApplyToAll.Checked;
+			applyToAll = cbApplyToAll.Checked; //mxd
 
 			this.Hide();
 		}
@@ -281,7 +280,10 @@ namespace CodeImp.DoomBuilder.BuilderModes
 		private void ClearSelectedResult()
 		{
 			results.SelectedIndex = -1;
-			resultinfo.Text = "Select a result from the list to see more information.\r\nRight-click on a result to show context menu.";
+			if (results.Items.Count == 0 && resultslist.Count > 0) //mxd
+				resultinfo.Text = "All results are hidden. Use context menu to show them.";
+			else 
+				resultinfo.Text = "Select a result from the list to see more information.\r\nRight-click on a result to show context menu.";
 			resultinfo.Enabled = false;
 			fix1.Visible = false;
 			fix2.Visible = false;
@@ -621,6 +623,7 @@ namespace CodeImp.DoomBuilder.BuilderModes
 
 			// Do the obvious
 			UpdateTitle();
+			ClearSelectedResult();
 		}
 
 		private void resulthidecurrent_Click(object sender, EventArgs e) 
@@ -632,6 +635,7 @@ namespace CodeImp.DoomBuilder.BuilderModes
 
 			// Do the obvious
 			UpdateTitle();
+			ClearSelectedResult();
 		}
 
 		private void resulthidecurrenttype_Click(object sender, EventArgs e)
@@ -654,6 +658,7 @@ namespace CodeImp.DoomBuilder.BuilderModes
 
 			// Do the obvious
 			UpdateTitle();
+			ClearSelectedResult();
 		}
 
 		private void resultshowonlycurrent_Click(object sender, EventArgs e) 
@@ -684,6 +689,7 @@ namespace CodeImp.DoomBuilder.BuilderModes
 
 			// Do the obvious
 			UpdateTitle();
+			ClearSelectedResult();
 		}
 
 		private void resultcopytoclipboard_Click(object sender, EventArgs e)