stjr/UltimateZoneBuilder
0
0
Fork 0
mirror of https://git.do.srb2.org/STJr/UltimateZoneBuilder.git synced 2024-11-23 04:12:12 +00:00
Code Issues Projects Releases Packages Wiki Activity

DeHackEd: fixed a crash with malformed patches. Fixes #673

Browse source
This commit is contained in:
biwa 2021-12-23 12:48:04 +01:00
parent 5d50279a9e
commit ca7b9e8b7e
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
Source/Core/Dehacked/DehackedParser.cs
View file

@ -489,6 +489,13 @@ namespace CodeImp.DoomBuilder.Dehacked
StringBuilder oldtext = new StringBuilder(textreplaceoldcount);
while (textreplaceoldcount > 0)
{
// Sanity check for malformed patches, for example in dbimpact.wad (see https://github.com/jewalky/UltimateDoomBuilder/issues/673)
if (datareader.EndOfStream)
{
LogError("Reached enexpected end of file when " + textreplaceoldcount + (textreplaceoldcount == 1 ? " more character was" : " more characters were") + " expected");
return false;
}
int c = datareader.Read();
// Dehacked patches use Windows style CRLF line endings, but text replacements
@ -505,6 +512,13 @@ namespace CodeImp.DoomBuilder.Dehacked
StringBuilder newtext = new StringBuilder();
while (textreplacenewcount > 0)
{
// Sanity check for malformed patches, for example in dbimpact.wad (see https://github.com/jewalky/UltimateDoomBuilder/issues/673)
if (datareader.EndOfStream)
{
LogWarning("Reached unexpected end of file when " + textreplacenewcount + (textreplacenewcount == 1 ? " more character was" : " more characters were") + " expected");
break;
}
int c = datareader.Read();
// Dehacked patches use Windows style CRLF line endings, but text replacements