added two error-check results for line references

This commit is contained in:
codeimp 2008-10-24 19:16:23 +00:00
parent 22d903c630
commit 415820af86
3 changed files with 244 additions and 2 deletions

View file

@ -78,12 +78,12 @@ namespace CodeImp.DoomBuilder.BuilderModes
// Line is marked double-sided, but has only one side?
else if(l.IsFlagSet(General.Map.Config.DoubleSidedFlag) && (l.Back == null))
{
// ERROR: Linedef is incorrectly marked double-sided
SubmitResult(new ResultLineNotDoubleSided(l));
}
// Line is marked single-sided, and has two sides?
else if(!l.IsFlagSet(General.Map.Config.DoubleSidedFlag) && (l.Back != null))
{
// ERROR: Linedef is incorrectly marked single-sided
SubmitResult(new ResultLineNotSingleSided(l));
}
// Handle thread interruption

View file

@ -0,0 +1,139 @@
#region ================== Copyright (c) 2007 Pascal vd Heiden
/*
* Copyright (c) 2007 Pascal vd Heiden, www.codeimp.com
* This program is released under GNU General Public License
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
*/
#endregion
#region ================== Namespaces
using System;
using System.Collections;
using System.Collections.Generic;
using System.Globalization;
using System.Text;
using System.Windows.Forms;
using System.IO;
using System.Reflection;
using CodeImp.DoomBuilder.Windows;
using CodeImp.DoomBuilder.IO;
using CodeImp.DoomBuilder.Map;
using CodeImp.DoomBuilder.Rendering;
using CodeImp.DoomBuilder.Geometry;
using CodeImp.DoomBuilder.Editing;
using CodeImp.DoomBuilder.Actions;
using CodeImp.DoomBuilder.Types;
using CodeImp.DoomBuilder.Config;
#endregion
namespace CodeImp.DoomBuilder.BuilderModes
{
public class ResultLineNotDoubleSided : ErrorResult
{
#region ================== Variables
private Linedef line;
private int buttons;
private Sidedef copysidedef;
#endregion
#region ================== Properties
public override int Buttons { get { return buttons; } }
public override string Button1Text { get { return "Make Single-Sided"; } }
public override string Button2Text { get { return "Create Sidedef"; } }
#endregion
#region ================== Constructor / Destructor
// Constructor
public ResultLineNotDoubleSided(Linedef l)
{
// Initialize
this.line = l;
this.description = "This linedef is marked as double-sided, but is missing the back sidedef. Click Make Single-Sided to remove the double-sided flag from the line.";
// One solution is to remove the double-sided flag
buttons = 1;
// Check if the linedef can join a sector on the side where it is missing a sidedef
bool fixable = false;
List<LinedefSide> sides = Tools.FindPotentialSectorAt(l, false);
if(sides != null)
{
foreach(LinedefSide sd in sides)
{
// If any of the sides lies along a sidedef, then we can copy
// that sidedef to fix the missing sidedef on this line.
if(sd.Front && (sd.Line.Front != null))
{
copysidedef = sd.Line.Front;
fixable = true;
break;
}
else if(!sd.Front && (sd.Line.Back != null))
{
copysidedef = sd.Line.Back;
fixable = true;
break;
}
}
}
// Fixable?
if(fixable)
{
buttons++;
this.description += " Or click Create Sidedef to rebuild the missing sidedef (making the line really double-sided).";
}
}
#endregion
#region ================== Methods
// This must return the string that is displayed in the listbox
public override string ToString()
{
return "Linedef is marked double-sided but has no back side";
}
// Rendering
public override void PlotSelection(IRenderer2D renderer)
{
renderer.PlotLinedef(line, General.Colors.Selection);
}
// Fix by flipping linedefs
public override bool Button1Click()
{
line.ApplySidedFlags();
General.Map.Map.Update();
return true;
}
// Fix by creating a sidedef
public override bool Button2Click()
{
Sidedef newside = General.Map.Map.CreateSidedef(line, false, copysidedef.Sector);
copysidedef.CopyPropertiesTo(newside);
line.ApplySidedFlags();
General.Map.Map.Update();
return true;
}
#endregion
}
}

View file

@ -0,0 +1,103 @@
#region ================== Copyright (c) 2007 Pascal vd Heiden
/*
* Copyright (c) 2007 Pascal vd Heiden, www.codeimp.com
* This program is released under GNU General Public License
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
*/
#endregion
#region ================== Namespaces
using System;
using System.Collections;
using System.Collections.Generic;
using System.Globalization;
using System.Text;
using System.Windows.Forms;
using System.IO;
using System.Reflection;
using CodeImp.DoomBuilder.Windows;
using CodeImp.DoomBuilder.IO;
using CodeImp.DoomBuilder.Map;
using CodeImp.DoomBuilder.Rendering;
using CodeImp.DoomBuilder.Geometry;
using CodeImp.DoomBuilder.Editing;
using CodeImp.DoomBuilder.Actions;
using CodeImp.DoomBuilder.Types;
using CodeImp.DoomBuilder.Config;
#endregion
namespace CodeImp.DoomBuilder.BuilderModes
{
public class ResultLineNotSingleSided : ErrorResult
{
#region ================== Variables
private Linedef line;
#endregion
#region ================== Properties
public override int Buttons { get { return 2; } }
public override string Button1Text { get { return "Make Double-Sided"; } }
public override string Button2Text { get { return "Remove Sidedef"; } }
#endregion
#region ================== Constructor / Destructor
// Constructor
public ResultLineNotSingleSided(Linedef l)
{
// Initialize
this.line = l;
this.description = "This linedef is marked as single-sided, but has both a front and a back sidedef. Click Make Double-Sided to flag the line as double-sided." +
" Or click Remove Sidedef to remove the sidedef on the back side (making the line really single-sided).";
}
#endregion
#region ================== Methods
// This must return the string that is displayed in the listbox
public override string ToString()
{
return "Linedef is marked single-sided but has two sides";
}
// Rendering
public override void PlotSelection(IRenderer2D renderer)
{
renderer.PlotLinedef(line, General.Colors.Selection);
}
// Fix by flipping linedefs
public override bool Button1Click()
{
line.ApplySidedFlags();
General.Map.Map.Update();
return true;
}
// Fix by creating a sidedef
public override bool Button2Click()
{
line.Back.Dispose();
line.ApplySidedFlags();
General.Map.Map.Update();
return true;
}
#endregion
}
}