stjr/Kart-Public
0
0
Fork 0
mirror of https://git.do.srb2.org/KartKrew/Kart-Public.git synced 2024-12-27 04:41:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

Prevent use after free of lump name in WAD compression-handling code.

Browse source 
Located by my new compiler! Also a nice, simple test commit for my new Git client...
This commit is contained in:
toaster 2022-07-16 12:51:22 +01:00
parent cd3774932e
commit b30e84b156
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/w_wad.c
View file

@ -611,8 +611,6 @@ static lumpinfo_t* ResGetLumpsZip (FILE* handle, UINT16* nlmp)
lump_p->name2 = Z_Calloc(zentry->namelen + 1, PU_STATIC, NULL); lump_p->name2 = Z_Calloc(zentry->namelen + 1, PU_STATIC, NULL);
strncpy(lump_p->name2, fullname, zentry->namelen); strncpy(lump_p->name2, fullname, zentry->namelen);
free(fullname);
switch(zentry->compression) switch(zentry->compression)
{ {
case 0: case 0:
@ -631,6 +629,8 @@ static lumpinfo_t* ResGetLumpsZip (FILE* handle, UINT16* nlmp)
lump_p->compression = CM_UNSUPPORTED; lump_p->compression = CM_UNSUPPORTED;
break; break;
} }
free(fullname);
} }
*nlmp = numlumps; *nlmp = numlumps;