From 8c78d86c3641675e6c5803afab052cf91055af03 Mon Sep 17 00:00:00 2001
From: mazmazz <mar.marcoz@outlook.com>
Date: Thu, 23 Aug 2018 16:46:40 -0400
Subject: [PATCH] Play the opposite type music (Digital/MIDI) when toggling
 between them in menu

* S_MusicInfo method to retrieve name, flags, and looping

(cherry picked from commit f6ec93198f0dcfa1d053cca88172c3e3c7ba310c)
---
 src/m_menu.c  | 38 ++++++++++++++++++++++++++++++++++++--
 src/s_sound.c | 19 +++++++++++++++++--
 src/s_sound.h |  2 +-
 3 files changed, 54 insertions(+), 5 deletions(-)

diff --git a/src/m_menu.c b/src/m_menu.c
index 2c82bf84..6a6875aa 100644
--- a/src/m_menu.c
+++ b/src/m_menu.c
@@ -6992,7 +6992,24 @@ static void M_ToggleDigital(void)
 	{
 		digital_disabled = true;
 		if (S_MusicType() != MU_MID)
-			S_StopMusic();
+		{
+			if (midi_disabled)
+				S_StopMusic();
+			else
+			{
+				char mmusic[7];
+				UINT16 mflags;
+				boolean looping;
+
+				if (S_MusicInfo(mmusic, &mflags, &looping) && S_MIDIExists(mmusic))
+				{
+					S_StopMusic();
+					S_ChangeMusic(mmusic, mflags, looping);
+				}
+				else
+					S_StopMusic();
+			}
+		}
 		M_StartMessage(M_GetText("Digital Music Disabled\n"), NULL, MM_NOTHING);
 	}
 }
@@ -7014,7 +7031,24 @@ static void M_ToggleMIDI(void)
 	{
 		midi_disabled = true;
 		if (S_MusicType() == MU_MID)
-			S_StopMusic();
+		{
+			if (digital_disabled)
+				S_StopMusic();
+			else
+			{
+				char mmusic[7];
+				UINT16 mflags;
+				boolean looping;
+
+				if (S_MusicInfo(mmusic, &mflags, &looping) && S_DigExists(mmusic))
+				{
+					S_StopMusic();
+					S_ChangeMusic(mmusic, mflags, looping);
+				}
+				else
+					S_StopMusic();
+			}
+		}
 		M_StartMessage(M_GetText("MIDI Music Disabled\n"), NULL, MM_NOTHING);
 	}
 }
diff --git a/src/s_sound.c b/src/s_sound.c
index 54ffffc4..32d9c7b0 100644
--- a/src/s_sound.c
+++ b/src/s_sound.c
@@ -1215,6 +1215,8 @@ const char *compat_special_music_slots[16] =
 #endif
 
 static char      music_name[7]; // up to 6-character name
+static UINT16    music_flags;
+static boolean   music_looping;
 
 /// ------------------------
 /// Music Status
@@ -1250,9 +1252,17 @@ musictype_t S_MusicType(void)
 	return I_GetMusicType();
 }
 
-const char *S_MusicName(void)
+boolean S_MusicInfo(char *mname, UINT16 *mflags, boolean *looping)
 {
-	return music_name;
+	if (!I_MusicPlaying())
+		return false;
+
+	strncpy(mname, music_name, 7);
+	mname[6] = 0;
+	*mflags = music_flags;
+	*looping = music_looping;
+
+	return (boolean)mname[0];
 }
 
 boolean S_MusicExists(const char *mname, boolean checkMIDI, boolean checkDigi)
@@ -1333,6 +1343,8 @@ static void S_UnloadMusic(void)
 {
 	I_UnloadSong();
 	music_name[0] = 0;
+	music_flags = 0;
+	music_looping = false;
 }
 
 static boolean S_PlayMusic(boolean looping)
@@ -1373,6 +1385,9 @@ void S_ChangeMusic(const char *mmusic, UINT16 mflags, boolean looping)
 		if (!S_LoadMusic(mmusic))
 			return;
 
+		music_flags = mflags;
+		music_looping = looping;
+
 		if (!S_PlayMusic(looping))
 		{
 			CONS_Alert(CONS_ERROR, "Music cannot be played!\n");
diff --git a/src/s_sound.h b/src/s_sound.h
index a0ac6c15..a2d51a59 100644
--- a/src/s_sound.h
+++ b/src/s_sound.h
@@ -108,7 +108,7 @@ boolean S_MusicDisabled(void);
 boolean S_MusicPlaying(void);
 boolean S_MusicPaused(void);
 musictype_t S_MusicType(void);
-const char *S_MusicName(void);
+boolean S_MusicInfo(char *mname, UINT16 *mflags, boolean *looping);
 boolean S_MusicExists(const char *mname, boolean checkMIDI, boolean checkDigi);
 #define S_DigExists(a) S_MusicExists(a, false, true)
 #define S_MIDIExists(a) S_MusicExists(a, true, false)