stjr/Kart-Public
0
0
Fork 0
mirror of https://git.do.srb2.org/KartKrew/Kart-Public.git synced 2025-01-16 06:30:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

Open a new connection before we check socket errors

Browse source 
And somehow this applies if you use `addfile` after having added the server.
Some claim that there are other cases too.
This commit is contained in:
James R 2019-02-09 07:50:26 +00:00
parent 1c3fe3ce83
commit 55430e3068
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/mserv.c
View file

@ -700,7 +700,13 @@ static INT32 AddToMasterServer(boolean firstadd)
return MS_CONNECT_ERROR; return MS_CONNECT_ERROR;
} }
retry = 0; retry = 0;
if (res == ERRSOCKET) /*
Somehow we can still select our old socket despite it being closed(?).
Atleast, that's what I THINK is happening. Anyway, we have to check that we
haven't open a socket, and actually open it!
*/
/*if (res == ERRSOCKET)*//* wtf? no! */
if (socket_fd == ERRSOCKET)
{ {
if (MS_Connect(GetMasterServerIP(), GetMasterServerPort(), 0)) if (MS_Connect(GetMasterServerIP(), GetMasterServerPort(), 0))
{ {
@ -714,6 +720,13 @@ static INT32 AddToMasterServer(boolean firstadd)
// ok, or bad... let see that! // ok, or bad... let see that!
j = (socklen_t)sizeof (i); j = (socklen_t)sizeof (i);
getsockopt(socket_fd, SOL_SOCKET, SO_ERROR, (char *)&i, &j); getsockopt(socket_fd, SOL_SOCKET, SO_ERROR, (char *)&i, &j);
/*
This is also wrong. If getsockopt fails, i doesn't have to be set. Plus, if
it is set (which it appearantly is on linux), we check errno anyway. And in
the case that i is returned as normal, we don't even report the correct
value! So we accomplish NOTHING, except returning due to dumb luck.
If you care, fix this--I don't. -James (R.)
*/
if (i) // it was bad if (i) // it was bad
{ {
CONS_Alert(CONS_ERROR, M_GetText("Master Server socket error #%u: %s\n"), errno, strerror(errno)); CONS_Alert(CONS_ERROR, M_GetText("Master Server socket error #%u: %s\n"), errno, strerror(errno));