diff --git a/reaction/Makefile b/reaction/Makefile index c96d4fbf..383f8c94 100644 --- a/reaction/Makefile +++ b/reaction/Makefile @@ -270,7 +270,6 @@ ifneq (,$(findstring "$(PLATFORM)", "linux" "gnu_kfreebsd" "kfreebsd-gnu")) BASE_CFLAGS = -Wall -fno-strict-aliasing -Wimplicit -Wstrict-prototypes \ -pipe -DUSE_ICON - BASE_CFLAGS += -Wno-unused-but-set-variable CLIENT_CFLAGS = $(SDL_CFLAGS) SERVER_CFLAGS = diff --git a/reaction/code/botlib/be_aas_cluster.c b/reaction/code/botlib/be_aas_cluster.c index e2b86d53..6c029eeb 100644 --- a/reaction/code/botlib/be_aas_cluster.c +++ b/reaction/code/botlib/be_aas_cluster.c @@ -811,7 +811,7 @@ int AAS_CheckAreaForPossiblePortals(int areanum) // Com_Memset(numareafrontfaces, 0, sizeof(numareafrontfaces)); Com_Memset(numareabackfaces, 0, sizeof(numareabackfaces)); - numareas = numfrontfaces = numbackfaces = 0; + numfrontfaces = numbackfaces = 0; numfrontareas = numbackareas = 0; frontplanenum = backplanenum = -1; //add any adjacent areas with less presence types diff --git a/reaction/code/botlib/be_aas_move.c b/reaction/code/botlib/be_aas_move.c index fded262d..c42b6cca 100644 --- a/reaction/code/botlib/be_aas_move.c +++ b/reaction/code/botlib/be_aas_move.c @@ -382,18 +382,6 @@ void AAS_Accelerate(vec3_t velocity, float frametime, vec3_t wishdir, float wish } } //end of the function AAS_Accelerate //=========================================================================== -// -// Parameter: - -// Returns: - -// Changes Globals: - -//=========================================================================== -void AAS_AirControl(vec3_t start, vec3_t end, vec3_t velocity, vec3_t cmdmove) -{ - vec3_t dir; - - VectorSubtract(end, start, dir); -} //end of the function AAS_AirControl -//=========================================================================== // applies ground friction to the given velocity // // Parameter: - @@ -518,7 +506,8 @@ int AAS_ClientMovementPrediction(struct aas_clientmove_s *move, float phys_maxstep, phys_maxsteepness, phys_jumpvel, friction; float gravity, delta, maxvel, wishspeed, accelerate; //float velchange, newvel; - int n, i, j, pc, step, swimming, ax, crouch, event, jump_frame, areanum; + //int ax; + int n, i, j, pc, step, swimming, crouch, event, jump_frame, areanum; int areas[20], numareas; vec3_t points[20]; vec3_t org, end, feet, start, stepend, lastorg, wishdir; @@ -574,7 +563,7 @@ int AAS_ClientMovementPrediction(struct aas_clientmove_s *move, //apply command movement if (n < cmdframes) { - ax = 0; + //ax = 0; maxvel = phys_maxwalkvelocity; accelerate = phys_airaccelerate; VectorCopy(cmdmove, wishdir); @@ -598,13 +587,13 @@ int AAS_ClientMovementPrediction(struct aas_clientmove_s *move, { accelerate = phys_walkaccelerate; } //end else - ax = 2; + //ax = 2; } //end if if (swimming) { maxvel = phys_maxswimvelocity; accelerate = phys_swimaccelerate; - ax = 3; + //ax = 3; } //end if else { diff --git a/reaction/code/botlib/be_aas_reach.c b/reaction/code/botlib/be_aas_reach.c index 291325be..6c457958 100644 --- a/reaction/code/botlib/be_aas_reach.c +++ b/reaction/code/botlib/be_aas_reach.c @@ -289,7 +289,7 @@ int AAS_GetJumpPadInfo(int ent, vec3_t areastart, vec3_t absmins, vec3_t absmaxs //=========================================================================== int AAS_BestReachableFromJumpPadArea(vec3_t origin, vec3_t mins, vec3_t maxs) { - int area2num, ent, bot_visualizejumppads, bestareanum; + int ent, bot_visualizejumppads, bestareanum; float volume, bestareavolume; vec3_t areastart, cmdmove, bboxmins, bboxmaxs; vec3_t absmins, absmaxs, velocity; @@ -327,7 +327,6 @@ int AAS_BestReachableFromJumpPadArea(vec3_t origin, vec3_t mins, vec3_t maxs) // VectorSet(cmdmove, 0, 0, 0); Com_Memset(&move, 0, sizeof(aas_clientmove_t)); - area2num = 0; AAS_ClientMovementHitBBox(&move, -1, areastart, PRESENCE_NORMAL, qfalse, velocity, cmdmove, 0, 30, 0.1f, bboxmins, bboxmaxs, bot_visualizejumppads); if (move.frames < 30) @@ -837,7 +836,6 @@ int AAS_Reachability_Swim(int area1num, int area2num) { int i, j, face1num, face2num, side1; aas_area_t *area1, *area2; - aas_areasettings_t *areasettings; aas_lreachability_t *lreach; aas_face_t *face1; aas_plane_t *plane; @@ -875,7 +873,6 @@ int AAS_Reachability_Swim(int area1num, int area2num) { // face1 = &aasworld.faces[face1num]; - areasettings = &aasworld.areasettings[area1num]; //create a new reachability link lreach = AAS_AllocReachability(); if (!lreach) return qfalse; @@ -1062,7 +1059,8 @@ int AAS_Reachability_Step_Barrier_WaterJump_WalkOffLedge(int area1num, int area2 int ground_bestarea2groundedgenum, ground_foundreach; int water_bestarea2groundedgenum, water_foundreach; int side1, area1swim, faceside1, groundface1num; - float dist, dist1, dist2, diff, invgravitydot, ortdot; + float dist, dist1, dist2, diff, ortdot; + //float invgravitydot; float x1, x2, x3, x4, y1, y2, y3, y4, tmp, y; float length, ground_bestlength, water_bestlength, ground_bestdist, water_bestdist; vec3_t v1, v2, v3, v4, tmpv, p1area1, p1area2, p2area1, p2area2; @@ -1073,7 +1071,7 @@ int AAS_Reachability_Step_Barrier_WaterJump_WalkOffLedge(int area1num, int area2 vec3_t testpoint; aas_plane_t *plane; aas_area_t *area1, *area2; - aas_face_t *groundface1, *groundface2, *ground_bestface1, *water_bestface1; + aas_face_t *groundface1, *groundface2; aas_edge_t *edge1, *edge2; aas_lreachability_t *lreach; aas_trace_t trace; @@ -1172,7 +1170,7 @@ int AAS_Reachability_Step_Barrier_WaterJump_WalkOffLedge(int area1num, int area2 //edges if they overlap in the direction orthogonal to //the gravity direction CrossProduct(invgravity, normal, ort); - invgravitydot = DotProduct(invgravity, invgravity); + //invgravitydot = DotProduct(invgravity, invgravity); ortdot = DotProduct(ort, ort); //projection into the step plane //NOTE: since gravity is vertical this is just the z coordinate @@ -1302,7 +1300,6 @@ int AAS_Reachability_Step_Barrier_WaterJump_WalkOffLedge(int area1num, int area2 ground_bestlength = length; ground_foundreach = qtrue; ground_bestarea2groundedgenum = edge1num; - ground_bestface1 = groundface1; //best point towards area1 VectorCopy(start, ground_beststart); //normal is pointing into area2 @@ -1323,7 +1320,6 @@ int AAS_Reachability_Step_Barrier_WaterJump_WalkOffLedge(int area1num, int area2 water_bestlength = length; water_foundreach = qtrue; water_bestarea2groundedgenum = edge1num; - water_bestface1 = groundface1; //best point towards area1 VectorCopy(start, water_beststart); //normal is pointing into area2 @@ -2852,9 +2848,9 @@ void AAS_Reachability_Teleport(void) botimport.Print(PRT_ERROR, "teleporter destination (%s) in solid\n", target); continue; } //end if + /* area2num = AAS_PointAreaNum(trace.endpos); // - /* if (!AAS_AreaTeleporter(area2num) && !AAS_AreaJumpPad(area2num) && !AAS_AreaGrounded(area2num)) @@ -3396,7 +3392,6 @@ void AAS_Reachability_FuncBobbing(void) // for (i = 0; i < 2; i++) { - firststartreach = firstendreach = NULL; // if (i == 0) { @@ -3492,7 +3487,8 @@ void AAS_Reachability_JumpPad(void) int face2num, i, ret, area2num, visualize, ent, bot_visualizejumppads; //int modelnum, ent2; //float dist, time, height, gravity, forward; - float speed, zvel, hordist; + float speed, zvel; + //float hordist; aas_face_t *face2; aas_area_t *area2; aas_lreachability_t *lreach; @@ -3714,7 +3710,7 @@ void AAS_Reachability_JumpPad(void) //direction towards the face center VectorSubtract(facecenter, areastart, dir); dir[2] = 0; - hordist = VectorNormalize(dir); + //hordist = VectorNormalize(dir); //if (hordist < 1.6 * facecenter[2] - areastart[2]) { //get command movement @@ -3997,7 +3993,8 @@ void AAS_SetWeaponJumpAreaFlags(void) int AAS_Reachability_WeaponJump(int area1num, int area2num) { int face2num, i, n, ret, visualize; - float speed, zvel, hordist; + float speed, zvel; + //float hordist; aas_face_t *face2; aas_area_t *area1, *area2; aas_lreachability_t *lreach; @@ -4057,7 +4054,7 @@ int AAS_Reachability_WeaponJump(int area1num, int area2num) //direction towards the face center VectorSubtract(facecenter, areastart, dir); dir[2] = 0; - hordist = VectorNormalize(dir); + //hordist = VectorNormalize(dir); //if (hordist < 1.6 * (facecenter[2] - areastart[2])) { //get command movement diff --git a/reaction/code/botlib/be_aas_route.c b/reaction/code/botlib/be_aas_route.c index 583d2206..1d57b530 100644 --- a/reaction/code/botlib/be_aas_route.c +++ b/reaction/code/botlib/be_aas_route.c @@ -506,9 +506,11 @@ void AAS_CalculateAreaTravelTimes(void) aas_reversedlink_t *revlink; aas_reachability_t *reach; aas_areasettings_t *settings; +#ifdef DEBUG int starttime; starttime = Sys_MilliSeconds(); +#endif //if there are still area travel times, free the memory if (aasworld.areatraveltimes) FreeMemory(aasworld.areatraveltimes); //get the total size of all the area travel times @@ -887,7 +889,8 @@ void AAS_InitRoutingUpdate(void) //=========================================================================== void AAS_CreateAllRoutingCache(void) { - int i, j, t; + int i, j; + //int t; aasworld.initialized = qtrue; botimport.Print(PRT_MESSAGE, "AAS_CreateAllRoutingCache\n"); @@ -898,7 +901,8 @@ void AAS_CreateAllRoutingCache(void) { if (i == j) continue; if (!AAS_AreaReachability(j)) continue; - t = AAS_AreaTravelTimeToGoalArea(i, aasworld.areas[i].center, j, TFL_DEFAULT); + AAS_AreaTravelTimeToGoalArea(i, aasworld.areas[i].center, j, TFL_DEFAULT); + //t = AAS_AreaTravelTimeToGoalArea(i, aasworld.areas[i].center, j, TFL_DEFAULT); //Log_Write("traveltime from %d to %d is %d", i, j, t); } //end for } //end for diff --git a/reaction/code/botlib/be_ai_chat.c b/reaction/code/botlib/be_ai_chat.c index 7df77c3f..10950e9d 100644 --- a/reaction/code/botlib/be_ai_chat.c +++ b/reaction/code/botlib/be_ai_chat.c @@ -844,7 +844,6 @@ void BotReplaceReplySynonyms(char *string, unsigned long int context) if (!(syn->context & context)) continue; for (synonym = syn->firstsynonym->next; synonym; synonym = synonym->next) { - str2 = synonym->string; //if the synonym is not at the front of the string continue str2 = StringContainsWord(str1, synonym->string, qfalse); if (!str2 || str2 != str1) continue; @@ -2939,7 +2938,6 @@ int BotAllocChatState(void) //======================================================================== void BotFreeChatState(int handle) { - bot_chatstate_t *cs; bot_consolemessage_t m; int h; @@ -2953,7 +2951,6 @@ void BotFreeChatState(int handle) botimport.Print(PRT_FATAL, "invalid chat state %d\n", handle); return; } //end if - cs = botchatstates[handle]; if (LibVarGetValue("bot_reloadcharacters")) { BotFreeChatFile(handle); diff --git a/reaction/code/botlib/be_ai_gen.c b/reaction/code/botlib/be_ai_gen.c index d7bb2214..5839f8a1 100644 --- a/reaction/code/botlib/be_ai_gen.c +++ b/reaction/code/botlib/be_ai_gen.c @@ -51,7 +51,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA //=========================================================================== int GeneticSelection(int numranks, float *rankings) { - float sum, select; + float sum; int i, index; sum = 0; @@ -64,7 +64,7 @@ int GeneticSelection(int numranks, float *rankings) { //select a bot where the ones with the higest rankings have //the highest chance of being selected - select = random() * sum; + //sum *= random(); for (i = 0; i < numranks; i++) { if (rankings[i] < 0) continue; diff --git a/reaction/code/botlib/be_ai_goal.c b/reaction/code/botlib/be_ai_goal.c index 8fb7de9a..538a82e0 100644 --- a/reaction/code/botlib/be_ai_goal.c +++ b/reaction/code/botlib/be_ai_goal.c @@ -238,9 +238,9 @@ void BotInterbreedGoalFuzzyLogic(int parent1, int parent2, int child) //=========================================================================== void BotSaveGoalFuzzyLogic(int goalstate, char *filename) { - bot_goalstate_t *gs; + //bot_goalstate_t *gs; - gs = BotGoalStateFromHandle(goalstate); + //gs = BotGoalStateFromHandle(goalstate); //WriteWeightConfig(filename, gs->itemweightconfig); } //end of the function BotSaveGoalFuzzyLogic diff --git a/reaction/code/botlib/be_ai_move.c b/reaction/code/botlib/be_ai_move.c index 294fc257..43e9a337 100644 --- a/reaction/code/botlib/be_ai_move.c +++ b/reaction/code/botlib/be_ai_move.c @@ -848,7 +848,6 @@ int BotMovementViewTarget(int movestate, bot_goal_t *goal, int travelflags, floa ms = BotMoveStateFromHandle(movestate); if (!ms) return qfalse; - reachnum = 0; //if the bot has no goal or no last reachability if (!ms->lastreachnum || !goal) return qfalse; @@ -997,12 +996,13 @@ void MoverBottomCenter(aas_reachability_t *reach, vec3_t bottomcenter) //=========================================================================== float BotGapDistance(vec3_t origin, vec3_t hordir, int entnum) { - float dist, startz; + int dist; + float startz; vec3_t start, end; aas_trace_t trace; //do gap checking - startz = origin[2]; + //startz = origin[2]; //this enables walking down stairs more fluidly { VectorCopy(origin, start); @@ -1030,7 +1030,7 @@ float BotGapDistance(vec3_t origin, vec3_t hordir, int entnum) end[2] -= 20; if (AAS_PointContents(end) & CONTENTS_WATER) break; //if a gap is found slow down - //botimport.Print(PRT_MESSAGE, "gap at %f\n", dist); + //botimport.Print(PRT_MESSAGE, "gap at %i\n", dist); return dist; } //end if startz = trace.endpos[2]; @@ -1480,7 +1480,6 @@ bot_moveresult_t BotTravel_BarrierJump(bot_movestate_t *ms, aas_reachability_t * //=========================================================================== bot_moveresult_t BotFinishTravel_BarrierJump(bot_movestate_t *ms, aas_reachability_t *reach) { - float dist; vec3_t hordir; bot_moveresult_t_cleared( result ); @@ -1490,7 +1489,6 @@ bot_moveresult_t BotFinishTravel_BarrierJump(bot_movestate_t *ms, aas_reachabili hordir[0] = reach->end[0] - ms->origin[0]; hordir[1] = reach->end[1] - ms->origin[1]; hordir[2] = 0; - dist = VectorNormalize(hordir); // BotCheckBlocked(ms, hordir, qtrue, &result); // @@ -1567,7 +1565,6 @@ bot_moveresult_t BotTravel_WaterJump(bot_movestate_t *ms, aas_reachability_t *re bot_moveresult_t BotFinishTravel_WaterJump(bot_movestate_t *ms, aas_reachability_t *reach) { vec3_t dir, pnt; - float dist; bot_moveresult_t_cleared( result ); //botimport.Print(PRT_MESSAGE, "BotFinishTravel_WaterJump\n"); @@ -1583,7 +1580,6 @@ bot_moveresult_t BotFinishTravel_WaterJump(bot_movestate_t *ms, aas_reachability dir[0] += crandom() * 10; dir[1] += crandom() * 10; dir[2] += 70 + crandom() * 10; - dist = VectorNormalize(dir); //elemantary actions EA_Move(ms->client, dir, 400); //set the ideal view angles @@ -1721,7 +1717,6 @@ bot_moveresult_t BotFinishTravel_WalkOffLedge(bot_movestate_t *ms, aas_reachabil VectorCopy(dir, hordir); hordir[2] = 0; // - dist = VectorNormalize(hordir); speed = 400; } //end if // @@ -1788,6 +1783,7 @@ bot_moveresult_t BotTravel_Jump(bot_movestate_t *ms, aas_reachability_t *reach) bot_moveresult_t BotTravel_Jump(bot_movestate_t *ms, aas_reachability_t *reach) { vec3_t hordir, dir1, dir2, mins, maxs, start, end; + int gapdist; float dist1, dist2, speed; bot_moveresult_t_cleared( result ); bsp_trace_t trace; @@ -1808,13 +1804,13 @@ bot_moveresult_t BotTravel_Jump(bot_movestate_t *ms, aas_reachability_t *reach) trace = AAS_Trace(start, mins, maxs, end, ms->entitynum, MASK_PLAYERSOLID); if (trace.startsolid) VectorCopy(start, trace.endpos); //check for a gap - for (dist1 = 0; dist1 < 80; dist1 += 10) + for (gapdist = 0; gapdist < 80; gapdist += 10) { - VectorMA(start, dist1+10, hordir, end); + VectorMA(start, gapdist+10, hordir, end); end[2] += 1; if (AAS_PointAreaNum(end) != ms->reachareanum) break; } //end for - if (dist1 < 80) VectorMA(reach->start, dist1, hordir, trace.endpos); + if (gapdist < 80) VectorMA(reach->start, gapdist, hordir, trace.endpos); // dist1 = BotGapDistance(start, hordir, ms->entitynum); // if (dist1 && dist1 <= trace.fraction * 80) VectorMA(reach->start, dist1-20, hordir, trace.endpos); // @@ -1860,6 +1856,7 @@ bot_moveresult_t BotTravel_Jump(bot_movestate_t *ms, aas_reachability_t *reach) { vec3_t hordir, dir1, dir2, start, end, runstart; // vec3_t runstart, dir1, dir2, hordir; + int gapdist; float dist1, dist2, speed; bot_moveresult_t_cleared( result ); @@ -1875,13 +1872,13 @@ bot_moveresult_t BotTravel_Jump(bot_movestate_t *ms, aas_reachability_t *reach) start[2] += 1; VectorMA(reach->start, 80, hordir, runstart); //check for a gap - for (dist1 = 0; dist1 < 80; dist1 += 10) + for (gapdist = 0; gapdist < 80; gapdist += 10) { - VectorMA(start, dist1+10, hordir, end); + VectorMA(start, gapdist+10, hordir, end); end[2] += 1; if (AAS_PointAreaNum(end) != ms->reachareanum) break; } //end for - if (dist1 < 80) VectorMA(reach->start, dist1, hordir, runstart); + if (gapdist < 80) VectorMA(reach->start, gapdist, hordir, runstart); // VectorSubtract(ms->origin, reach->start, dir1); dir1[2] = 0; @@ -2867,7 +2864,6 @@ bot_moveresult_t BotFinishTravel_WeaponJump(bot_movestate_t *ms, aas_reachabilit //=========================================================================== bot_moveresult_t BotTravel_JumpPad(bot_movestate_t *ms, aas_reachability_t *reach) { - float dist, speed; vec3_t hordir; bot_moveresult_t_cleared( result ); @@ -2875,12 +2871,10 @@ bot_moveresult_t BotTravel_JumpPad(bot_movestate_t *ms, aas_reachability_t *reac hordir[0] = reach->start[0] - ms->origin[0]; hordir[1] = reach->start[1] - ms->origin[1]; hordir[2] = 0; - dist = VectorNormalize(hordir); // BotCheckBlocked(ms, hordir, qtrue, &result); - speed = 400; //elemantary action move in direction - EA_Move(ms->client, hordir, speed); + EA_Move(ms->client, hordir, 400); VectorCopy(hordir, result.movedir); // return result; diff --git a/reaction/code/botlib/l_precomp.c b/reaction/code/botlib/l_precomp.c index f560f2bb..af9e068d 100644 --- a/reaction/code/botlib/l_precomp.c +++ b/reaction/code/botlib/l_precomp.c @@ -1698,7 +1698,6 @@ int PC_EvaluateTokens(source_t *source, token_t *tokens, signed long int *intval int questmarkintvalue = 0; float questmarkfloatvalue = 0; int gotquestmarkvalue = qfalse; - int lastoperatortype = 0; // operator_t operator_heap[MAX_OPERATORS]; int numoperators = 0; @@ -2087,7 +2086,6 @@ int PC_EvaluateTokens(source_t *source, token_t *tokens, signed long int *intval else Log_Write("result value = %f", v1->floatvalue); #endif //DEBUG_EVAL if (error) break; - lastoperatortype = o->operator; //if not an operator with arity 1 if (o->operator != P_LOGIC_NOT && o->operator != P_BIN_NOT) diff --git a/reaction/code/client/cl_cgame.c b/reaction/code/client/cl_cgame.c index 5ed30191..c17ddf52 100644 --- a/reaction/code/client/cl_cgame.c +++ b/reaction/code/client/cl_cgame.c @@ -842,7 +842,6 @@ or bursted delayed packets. #define RESET_TIME 500 void CL_AdjustTimeDelta( void ) { - int resetTime; int newDelta; int deltaDelta; @@ -853,13 +852,6 @@ void CL_AdjustTimeDelta( void ) { return; } - // if the current time is WAY off, just correct to the current value - if ( com_sv_running->integer ) { - resetTime = 100; - } else { - resetTime = RESET_TIME; - } - newDelta = cl.snap.serverTime - cls.realtime; deltaDelta = abs( newDelta - cl.serverTimeDelta ); diff --git a/reaction/code/client/cl_cin.c b/reaction/code/client/cl_cin.c index ed2529ce..8f3a5cbf 100644 --- a/reaction/code/client/cl_cin.c +++ b/reaction/code/client/cl_cin.c @@ -937,10 +937,6 @@ static void setupQuad( long xOff, long yOff ) cin.oldysize = cinTable[currentHandle].ysize; cin.oldxsize = cinTable[currentHandle].xsize; - numQuadCels = (cinTable[currentHandle].CIN_WIDTH*cinTable[currentHandle].CIN_HEIGHT) / (16); - numQuadCels += numQuadCels/4 + numQuadCels/16; - numQuadCels += 64; // for overflow - numQuadCels = (cinTable[currentHandle].xsize*cinTable[currentHandle].ysize) / (16); numQuadCels += numQuadCels/4; numQuadCels += 64; // for overflow @@ -1610,7 +1606,6 @@ void CIN_DrawCinematic (int handle) { void CL_PlayCinematic_f(void) { char *arg, *s; - qboolean holdatend; int bits = CIN_system; Com_DPrintf("CL_PlayCinematic_f\n"); @@ -1621,7 +1616,6 @@ void CL_PlayCinematic_f(void) { arg = Cmd_Argv( 1 ); s = Cmd_Argv(2); - holdatend = qfalse; if ((s && s[0] == '1') || Q_stricmp(arg,"demoend.roq")==0 || Q_stricmp(arg,"end.roq")==0) { bits |= CIN_hold; } diff --git a/reaction/code/client/cl_input.c b/reaction/code/client/cl_input.c index 3f2f3e06..e9612c24 100644 --- a/reaction/code/client/cl_input.c +++ b/reaction/code/client/cl_input.c @@ -279,10 +279,6 @@ void IN_CenterView (void) { //========================================================================== -cvar_t *cl_upspeed; -cvar_t *cl_forwardspeed; -cvar_t *cl_sidespeed; - cvar_t *cl_yawspeed; cvar_t *cl_pitchspeed; @@ -399,13 +395,9 @@ CL_JoystickMove ================= */ void CL_JoystickMove( usercmd_t *cmd ) { - int movespeed; float anglespeed; - if ( in_speed.active ^ cl_run->integer ) { - movespeed = 2; - } else { - movespeed = 1; + if ( !(in_speed.active ^ cl_run->integer) ) { cmd->buttons |= BUTTON_WALKING; } @@ -617,10 +609,10 @@ usercmd_t CL_CreateCmd( void ) { // draw debug graphs of turning for mouse testing if ( cl_debugMove->integer ) { if ( cl_debugMove->integer == 1 ) { - SCR_DebugGraph( abs(cl.viewangles[YAW] - oldAngles[YAW]), 0 ); + SCR_DebugGraph( abs(cl.viewangles[YAW] - oldAngles[YAW]) ); } if ( cl_debugMove->integer == 2 ) { - SCR_DebugGraph( abs(cl.viewangles[PITCH] - oldAngles[PITCH]), 0 ); + SCR_DebugGraph( abs(cl.viewangles[PITCH] - oldAngles[PITCH]) ); } } @@ -636,7 +628,6 @@ Create a new usercmd_t structure for this frame ================= */ void CL_CreateNewCommands( void ) { - usercmd_t *cmd; int cmdNum; // no need to create usercmds until we have a gamestate @@ -658,7 +649,6 @@ void CL_CreateNewCommands( void ) { cl.cmdNumber++; cmdNum = cl.cmdNumber & CMD_MASK; cl.cmds[cmdNum] = CL_CreateCmd (); - cmd = &cl.cmds[cmdNum]; } /* diff --git a/reaction/code/client/cl_main.c b/reaction/code/client/cl_main.c index 50c2e6b6..19c33196 100644 --- a/reaction/code/client/cl_main.c +++ b/reaction/code/client/cl_main.c @@ -440,9 +440,7 @@ void CL_CaptureVoip(void) // try to get more audio data from the sound card... if (initialFrame) { - float gain = cl_voipGainDuringCapture->value; - if (gain < 0.0f) gain = 0.0f; else if (gain >= 1.0f) gain = 1.0f; - S_MasterGain(cl_voipGainDuringCapture->value); + S_MasterGain(Com_Clamp(0.0f, 1.0f, cl_voipGainDuringCapture->value)); S_StartCapture(); CL_VoipNewGeneration(); CL_VoipParseTargets(); @@ -582,9 +580,8 @@ CL_ChangeReliableCommand ====================== */ void CL_ChangeReliableCommand( void ) { - int r, index, l; + int index, l; - r = clc.reliableSequence - (random() * 5); index = clc.reliableSequence & ( MAX_RELIABLE_COMMANDS - 1 ); l = strlen(clc.reliableCommands[ index ]); if ( l >= MAX_STRING_CHARS - 1 ) { @@ -3001,7 +2998,7 @@ void CL_Frame ( int msec ) { cls.realtime += cls.frametime; if ( cl_timegraph->integer ) { - SCR_DebugGraph ( cls.realFrametime * 0.25, 0 ); + SCR_DebugGraph ( cls.realFrametime * 0.25 ); } // see if we need to update any userinfo @@ -3803,10 +3800,8 @@ CL_GetServerStatus =================== */ serverStatus_t *CL_GetServerStatus( netadr_t from ) { - serverStatus_t *serverStatus; int i, oldest, oldestTime; - serverStatus = NULL; for (i = 0; i < MAX_SERVERSTATUSREQUESTS; i++) { if ( NET_CompareAdr( from, cl_serverStatusList[i].address ) ) { return &cl_serverStatusList[i]; @@ -4330,7 +4325,6 @@ qboolean CL_UpdateVisiblePings_f(int source) { if (slots < MAX_PINGREQUESTS) { serverInfo_t *server = NULL; - max = (source == AS_GLOBAL) ? MAX_GLOBAL_SERVERS : MAX_OTHER_SERVERS; switch (source) { case AS_LOCAL : server = &cls.localServers[0]; diff --git a/reaction/code/client/cl_scrn.c b/reaction/code/client/cl_scrn.c index 2ec46efc..11c7db8f 100644 --- a/reaction/code/client/cl_scrn.c +++ b/reaction/code/client/cl_scrn.c @@ -395,25 +395,18 @@ DEBUG GRAPH =============================================================================== */ -typedef struct -{ - float value; - int color; -} graphsamp_t; - static int current; -static graphsamp_t values[1024]; +static float values[1024]; /* ============== SCR_DebugGraph ============== */ -void SCR_DebugGraph (float value, int color) +void SCR_DebugGraph (float value) { - values[current&1023].value = value; - values[current&1023].color = color; - current++; + values[current] = value; + current = (current + 1) % ARRAY_LEN(values); } /* @@ -425,7 +418,6 @@ void SCR_DrawDebugGraph (void) { int a, x, y, w, i, h; float v; - int color; // // draw the graph @@ -440,9 +432,8 @@ void SCR_DrawDebugGraph (void) for (a=0 ; ainteger + cl_graphshift->integer; if (v < 0) diff --git a/reaction/code/client/client.h b/reaction/code/client/client.h index c9d0eaca..96f6e977 100644 --- a/reaction/code/client/client.h +++ b/reaction/code/client/client.h @@ -564,7 +564,7 @@ void CL_SaveConsoleHistory( void ); void SCR_Init (void); void SCR_UpdateScreen (void); -void SCR_DebugGraph (float value, int color); +void SCR_DebugGraph (float value); int SCR_GetBigStringWidth( const char *str ); // returns in virtual 640x480 coordinates diff --git a/reaction/code/client/snd_codec_wav.c b/reaction/code/client/snd_codec_wav.c index e5a08ae9..2fd6aa53 100644 --- a/reaction/code/client/snd_codec_wav.c +++ b/reaction/code/client/snd_codec_wav.c @@ -131,7 +131,6 @@ S_ReadRIFFHeader static qboolean S_ReadRIFFHeader(fileHandle_t file, snd_info_t *info) { char dump[16]; - int wav_format; int bits; int fmtlen = 0; @@ -146,7 +145,7 @@ static qboolean S_ReadRIFFHeader(fileHandle_t file, snd_info_t *info) } // Save the parameters - wav_format = FGetLittleShort(file); + FGetLittleShort(file); // wav_format info->channels = FGetLittleShort(file); info->rate = FGetLittleLong(file); FGetLittleLong(file); diff --git a/reaction/code/client/snd_openal.c b/reaction/code/client/snd_openal.c index fe754ce3..74b63e18 100644 --- a/reaction/code/client/snd_openal.c +++ b/reaction/code/client/snd_openal.c @@ -353,8 +353,6 @@ S_AL_BufferUnload */ static void S_AL_BufferUnload(sfxHandle_t sfx) { - ALenum error; - if(knownSfx[sfx].filename[0] == '\0') return; @@ -364,7 +362,7 @@ static void S_AL_BufferUnload(sfxHandle_t sfx) // Delete it S_AL_ClearError( qfalse ); qalDeleteBuffers(1, &knownSfx[sfx].buffer); - if((error = qalGetError()) != AL_NO_ERROR) + if(qalGetError() != AL_NO_ERROR) Com_Printf( S_COLOR_RED "ERROR: Can't delete sound buffer for %s\n", knownSfx[sfx].filename); @@ -785,7 +783,6 @@ qboolean S_AL_SrcInit( void ) { int i; int limit; - ALenum error; // Clear the sources data structure memset(srcList, 0, sizeof(srcList)); @@ -804,7 +801,7 @@ qboolean S_AL_SrcInit( void ) for(i = 0; i < limit; i++) { qalGenSources(1, &srcList[i].alSource); - if((error = qalGetError()) != AL_NO_ERROR) + if(qalGetError() != AL_NO_ERROR) break; srcCount++; } @@ -3176,20 +3173,26 @@ qboolean S_AL_Init( soundInterface_t *si ) { char devicenames[16384] = ""; const char *devicelist; +#ifdef _WIN32 const char *defaultdevice; +#endif int curlen; // get all available devices + the default device name. if(enumeration_all_ext) { devicelist = qalcGetString(NULL, ALC_ALL_DEVICES_SPECIFIER); +#ifdef _WIN32 defaultdevice = qalcGetString(NULL, ALC_DEFAULT_ALL_DEVICES_SPECIFIER); +#endif } else { // We don't have ALC_ENUMERATE_ALL_EXT but normal enumeration. devicelist = qalcGetString(NULL, ALC_DEVICE_SPECIFIER); +#ifdef _WIN32 defaultdevice = qalcGetString(NULL, ALC_DEFAULT_DEVICE_SPECIFIER); +#endif enumeration_ext = qtrue; } diff --git a/reaction/code/libspeex/cb_search.c b/reaction/code/libspeex/cb_search.c index 63f4c6a4..39ad50c2 100644 --- a/reaction/code/libspeex/cb_search.c +++ b/reaction/code/libspeex/cb_search.c @@ -524,14 +524,15 @@ spx_int32_t *seed VARDECL(int *ind); VARDECL(int *signs); const signed char *shape_cb; - int shape_cb_size, subvect_size, nb_subvect; + //int shape_cb_size; + int subvect_size, nb_subvect; const split_cb_params *params; int have_sign; params = (const split_cb_params *) par; subvect_size = params->subvect_size; nb_subvect = params->nb_subvect; - shape_cb_size = 1<shape_bits; + //shape_cb_size = 1<shape_bits; shape_cb = params->shape_cb; have_sign = params->have_sign; diff --git a/reaction/code/libspeex/jitter.c b/reaction/code/libspeex/jitter.c index 6a32e754..a1fbd88e 100644 --- a/reaction/code/libspeex/jitter.c +++ b/reaction/code/libspeex/jitter.c @@ -463,7 +463,7 @@ int jitter_buffer_get(JitterBuffer *jitter, JitterBufferPacket *packet, spx_int3 { int i; unsigned int j; - int incomplete = 0; + //int incomplete = 0; spx_int16_t opt; if (start_offset != NULL) @@ -568,7 +568,7 @@ int jitter_buffer_get(JitterBuffer *jitter, JitterBufferPacket *packet, spx_int3 if (found) { i=besti; - incomplete = 1; + //incomplete = 1; /*fprintf (stderr, "incomplete: %d %d %d %d\n", jitter->packets[i].timestamp, jitter->pointer_timestamp, chunk_size, jitter->packets[i].span);*/ } } diff --git a/reaction/code/libspeex/nb_celp.c b/reaction/code/libspeex/nb_celp.c index 9dd726a0..52e360d2 100644 --- a/reaction/code/libspeex/nb_celp.c +++ b/reaction/code/libspeex/nb_celp.c @@ -1300,7 +1300,7 @@ int nb_decode(void *state, SpeexBits *bits, void *vout) { int offset; spx_word16_t *exc; - spx_word16_t *sp; + //spx_word16_t *sp; spx_word16_t *innov_save = NULL; spx_word16_t tmp; @@ -1309,7 +1309,7 @@ int nb_decode(void *state, SpeexBits *bits, void *vout) /* Excitation */ exc=st->exc+offset; /* Original signal */ - sp=out+offset; + //sp=out+offset; if (st->innov_save) innov_save = st->innov_save+offset; @@ -1502,13 +1502,13 @@ int nb_decode(void *state, SpeexBits *bits, void *vout) { int offset; spx_word16_t *sp; - spx_word16_t *exc; + //spx_word16_t *exc; /* Offset relative to start of frame */ offset = st->subframeSize*sub; /* Original signal */ sp=out+offset; /* Excitation */ - exc=st->exc+offset; + //exc=st->exc+offset; /* LSP interpolation (quantized and unquantized) */ lsp_interpolate(st->old_qlsp, qlsp, interp_qlsp, st->lpcSize, sub, st->nbSubframes); diff --git a/reaction/code/libspeex/vbr.c b/reaction/code/libspeex/vbr.c index 5b7dd9bf..33df777d 100644 --- a/reaction/code/libspeex/vbr.c +++ b/reaction/code/libspeex/vbr.c @@ -126,7 +126,7 @@ float vbr_analysis(VBRState *vbr, spx_word16_t *sig, int len, int pitch, float p int i; float ener=0, ener1=0, ener2=0; float qual=7; - int va; + //int va; float log_energy; float non_st=0; float voicing; @@ -159,7 +159,7 @@ float vbr_analysis(VBRState *vbr, spx_word16_t *sig, int len, int pitch, float p || (voicing<0 && non_st < .05)) { float tmp; - va = 0; + //va = 0; vbr->consec_noise++; if (pow_ener > 3*vbr->noise_level) tmp = 3*vbr->noise_level; @@ -171,7 +171,7 @@ float vbr_analysis(VBRState *vbr, spx_word16_t *sig, int len, int pitch, float p vbr->noise_accum_count = .95*vbr->noise_accum_count + .05; } } else { - va = 1; + //va = 1; vbr->consec_noise=0; } diff --git a/reaction/code/q3_ui/ui_connect.c b/reaction/code/q3_ui/ui_connect.c index 27db9562..4e5f1342 100644 --- a/reaction/code/q3_ui/ui_connect.c +++ b/reaction/code/q3_ui/ui_connect.c @@ -82,7 +82,7 @@ static void UI_DisplayDownloadInfo( const char *downloadName ) { downloadCount = trap_Cvar_VariableValue( "cl_downloadCount" ); downloadTime = trap_Cvar_VariableValue( "cl_downloadTime" ); - leftWidth = width = UI_ProportionalStringWidth( dlText ) * UI_ProportionalSizeScale( style ); + leftWidth = UI_ProportionalStringWidth( dlText ) * UI_ProportionalSizeScale( style ); width = UI_ProportionalStringWidth( etaText ) * UI_ProportionalSizeScale( style ); if (width > leftWidth) leftWidth = width; width = UI_ProportionalStringWidth( xferText ) * UI_ProportionalSizeScale( style ); diff --git a/reaction/code/q3_ui/ui_demo2.c b/reaction/code/q3_ui/ui_demo2.c index a16a762b..9a7fc134 100644 --- a/reaction/code/q3_ui/ui_demo2.c +++ b/reaction/code/q3_ui/ui_demo2.c @@ -111,20 +111,6 @@ static void Demos_MenuEvent( void *ptr, int event ) { } -/* -================= -UI_DemosMenu_Key -================= -*/ -static sfxHandle_t UI_DemosMenu_Key( int key ) { - menucommon_s *item; - - item = Menu_ItemAtCursor( &s_demos.menu ); - - return Menu_DefaultKey( &s_demos.menu, key ); -} - - /* =============== Demos_MenuInit @@ -137,7 +123,6 @@ static void Demos_MenuInit( void ) { int protocol, protocolLegacy; memset( &s_demos, 0 ,sizeof(demos_t) ); - s_demos.menu.key = UI_DemosMenu_Key; Demos_Cache(); diff --git a/reaction/code/q3_ui/ui_local.h b/reaction/code/q3_ui/ui_local.h index 5db3cef0..166a324a 100644 --- a/reaction/code/q3_ui/ui_local.h +++ b/reaction/code/q3_ui/ui_local.h @@ -623,7 +623,7 @@ void UI_SPSkillMenu_Cache( void ); // ui_syscalls.c // void trap_Print( const char *string ); -void trap_Error( const char *string ); +void trap_Error( const char *string ) __attribute__((noreturn)); int trap_Milliseconds( void ); void trap_Cvar_Register( vmCvar_t *vmCvar, const char *varName, const char *defaultValue, int flags ); void trap_Cvar_Update( vmCvar_t *vmCvar ); diff --git a/reaction/code/q3_ui/ui_mfield.c b/reaction/code/q3_ui/ui_mfield.c index d7b13fec..d2862ff4 100644 --- a/reaction/code/q3_ui/ui_mfield.c +++ b/reaction/code/q3_ui/ui_mfield.c @@ -334,7 +334,6 @@ void MenuField_Draw( menufield_s *f ) int x; int y; int w; - int h; int style; qboolean focus; float *color; @@ -345,13 +344,11 @@ void MenuField_Draw( menufield_s *f ) if (f->generic.flags & QMF_SMALLFONT) { w = SMALLCHAR_WIDTH; - h = SMALLCHAR_HEIGHT; style = UI_SMALLFONT; } else { w = BIGCHAR_WIDTH; - h = BIGCHAR_HEIGHT; style = UI_BIGFONT; } diff --git a/reaction/code/q3_ui/ui_servers2.c b/reaction/code/q3_ui/ui_servers2.c index f49b5e38..986fe254 100644 --- a/reaction/code/q3_ui/ui_servers2.c +++ b/reaction/code/q3_ui/ui_servers2.c @@ -739,13 +739,11 @@ void ArenaServers_LoadFavorites( void ) int i; int j; int numtempitems; - char emptyinfo[MAX_INFO_STRING]; char adrstr[MAX_ADDRESSLENGTH]; servernode_t templist[MAX_FAVORITESERVERS]; qboolean found; found = qfalse; - emptyinfo[0] = '\0'; // copy the old memcpy( templist, g_favoriteserverlist, sizeof(servernode_t)*MAX_FAVORITESERVERS ); diff --git a/reaction/code/q3_ui/ui_splevel.c b/reaction/code/q3_ui/ui_splevel.c index 4c7ebc95..17c9456c 100644 --- a/reaction/code/q3_ui/ui_splevel.c +++ b/reaction/code/q3_ui/ui_splevel.c @@ -725,7 +725,6 @@ static void UI_SPLevelMenu_Init( void ) { skill = (int)trap_Cvar_VariableValue( "g_spSkill" ); if( skill < 1 || skill > 5 ) { trap_Cvar_Set( "g_spSkill", "2" ); - skill = 2; } memset( &levelMenuInfo, 0, sizeof(levelMenuInfo) ); diff --git a/reaction/code/qcommon/cm_load.c b/reaction/code/qcommon/cm_load.c index a06358b9..1aa0fbe8 100644 --- a/reaction/code/qcommon/cm_load.c +++ b/reaction/code/qcommon/cm_load.c @@ -138,7 +138,7 @@ void CMod_LoadSubmodels( lump_t *l ) { Com_Error( ERR_DROP, "MAX_SUBMODELS exceeded" ); } - for ( i=0 ; iblocklist.next ; block->next != &zone->blocklist; block = block->next) { @@ -3105,7 +3111,6 @@ void Com_Frame( void ) { else minMsec = 1; - timeVal = 0; do { if(com_sv_running->integer) diff --git a/reaction/code/qcommon/files.c b/reaction/code/qcommon/files.c index f1e704ae..45a17d45 100644 --- a/reaction/code/qcommon/files.c +++ b/reaction/code/qcommon/files.c @@ -2443,7 +2443,7 @@ int FS_GetModList( char *listbuf, int bufsize ) { qboolean bDrop = qfalse; *listbuf = 0; - nMods = nPotential = nTotal = 0; + nMods = nTotal = 0; pFiles0 = Sys_ListFiles( fs_homepath->string, NULL, NULL, &dummy, qtrue ); pFiles1 = Sys_ListFiles( fs_basepath->string, NULL, NULL, &dummy, qtrue ); @@ -2946,7 +2946,7 @@ we are not interested in a download string format, we want something human-reada */ qboolean FS_ComparePaks( char *neededpaks, int len, qboolean dlstring ) { searchpath_t *sp; - qboolean havepak, badchecksum; + qboolean havepak; char *origpos = neededpaks; int i; @@ -2958,7 +2958,6 @@ qboolean FS_ComparePaks( char *neededpaks, int len, qboolean dlstring ) { for ( i = 0 ; i < fs_numServerReferencedPaks ; i++ ) { // Ok, see if we have this pak file - badchecksum = qfalse; havepak = qfalse; // never autodownload any of the id paks diff --git a/reaction/code/qcommon/msg.c b/reaction/code/qcommon/msg.c index e7d851fc..77666c6e 100644 --- a/reaction/code/qcommon/msg.c +++ b/reaction/code/qcommon/msg.c @@ -1208,7 +1208,6 @@ void MSG_WriteDeltaPlayerstate( msg_t *msg, struct playerState_s *from, struct p int ammobits; int powerupbits; int numFields; - int c; netField_t *field; int *fromF, *toF; float fullFloat; @@ -1219,8 +1218,6 @@ void MSG_WriteDeltaPlayerstate( msg_t *msg, struct playerState_s *from, struct p Com_Memset (&dummy, 0, sizeof(dummy)); } - c = msg->cursize; - numFields = ARRAY_LEN( playerStateFields ); lc = 0; @@ -1268,7 +1265,6 @@ void MSG_WriteDeltaPlayerstate( msg_t *msg, struct playerState_s *from, struct p MSG_WriteBits( msg, *toF, field->bits ); } } - c = msg->cursize - c; // diff --git a/reaction/code/qcommon/net_chan.c b/reaction/code/qcommon/net_chan.c index aa553b5d..0b099b95 100644 --- a/reaction/code/qcommon/net_chan.c +++ b/reaction/code/qcommon/net_chan.c @@ -243,7 +243,6 @@ copied out. */ qboolean Netchan_Process( netchan_t *chan, msg_t *msg ) { int sequence; - int qport; int fragmentStart, fragmentLength; qboolean fragmented; @@ -264,7 +263,7 @@ qboolean Netchan_Process( netchan_t *chan, msg_t *msg ) { // read the qport if we are a server if ( chan->sock == NS_SERVER ) { - qport = MSG_ReadShort( msg ); + MSG_ReadShort( msg ); } #ifdef LEGACY_PROTOCOL diff --git a/reaction/code/qcommon/net_ip.c b/reaction/code/qcommon/net_ip.c index fb336cfb..96bed147 100644 --- a/reaction/code/qcommon/net_ip.c +++ b/reaction/code/qcommon/net_ip.c @@ -1073,7 +1073,6 @@ NET_OpenSocks */ void NET_OpenSocks( int port ) { struct sockaddr_in address; - int err; struct hostent *h; int len; qboolean rfc1929; @@ -1084,14 +1083,12 @@ void NET_OpenSocks( int port ) { Com_Printf( "Opening connection to SOCKS server.\n" ); if ( ( socks_socket = socket( AF_INET, SOCK_STREAM, IPPROTO_TCP ) ) == INVALID_SOCKET ) { - err = socketError; Com_Printf( "WARNING: NET_OpenSocks: socket: %s\n", NET_ErrorString() ); return; } h = gethostbyname( net_socksServer->string ); if ( h == NULL ) { - err = socketError; Com_Printf( "WARNING: NET_OpenSocks: gethostbyname: %s\n", NET_ErrorString() ); return; } @@ -1104,7 +1101,6 @@ void NET_OpenSocks( int port ) { address.sin_port = htons( (short)net_socksPort->integer ); if ( connect( socks_socket, (struct sockaddr *)&address, sizeof( address ) ) == SOCKET_ERROR ) { - err = socketError; Com_Printf( "NET_OpenSocks: connect: %s\n", NET_ErrorString() ); return; } @@ -1132,7 +1128,6 @@ void NET_OpenSocks( int port ) { buf[2] = 2; // method #2 - method id #02: username/password } if ( send( socks_socket, (void *)buf, len, 0 ) == SOCKET_ERROR ) { - err = socketError; Com_Printf( "NET_OpenSocks: send: %s\n", NET_ErrorString() ); return; } @@ -1140,7 +1135,6 @@ void NET_OpenSocks( int port ) { // get the response len = recv( socks_socket, (void *)buf, 64, 0 ); if ( len == SOCKET_ERROR ) { - err = socketError; Com_Printf( "NET_OpenSocks: recv: %s\n", NET_ErrorString() ); return; } @@ -1179,7 +1173,6 @@ void NET_OpenSocks( int port ) { // send it if ( send( socks_socket, (void *)buf, 3 + ulen + plen, 0 ) == SOCKET_ERROR ) { - err = socketError; Com_Printf( "NET_OpenSocks: send: %s\n", NET_ErrorString() ); return; } @@ -1187,7 +1180,6 @@ void NET_OpenSocks( int port ) { // get the response len = recv( socks_socket, (void *)buf, 64, 0 ); if ( len == SOCKET_ERROR ) { - err = socketError; Com_Printf( "NET_OpenSocks: recv: %s\n", NET_ErrorString() ); return; } @@ -1209,7 +1201,6 @@ void NET_OpenSocks( int port ) { *(int *)&buf[4] = INADDR_ANY; *(short *)&buf[8] = htons( (short)port ); // port if ( send( socks_socket, (void *)buf, 10, 0 ) == SOCKET_ERROR ) { - err = socketError; Com_Printf( "NET_OpenSocks: send: %s\n", NET_ErrorString() ); return; } @@ -1217,7 +1208,6 @@ void NET_OpenSocks( int port ) { // get the response len = recv( socks_socket, (void *)buf, 64, 0 ); if( len == SOCKET_ERROR ) { - err = socketError; Com_Printf( "NET_OpenSocks: recv: %s\n", NET_ErrorString() ); return; } diff --git a/reaction/code/qcommon/q_shared.c b/reaction/code/qcommon/q_shared.c index 7285e51d..9f74e237 100644 --- a/reaction/code/qcommon/q_shared.c +++ b/reaction/code/qcommon/q_shared.c @@ -419,8 +419,9 @@ int COM_Compress( char *data_p ) { } } } + + *out = 0; } - *out = 0; return out - data_p; } diff --git a/reaction/code/qcommon/qcommon.h b/reaction/code/qcommon/qcommon.h index 37e3a3ae..57e4ac24 100644 --- a/reaction/code/qcommon/qcommon.h +++ b/reaction/code/qcommon/qcommon.h @@ -1027,7 +1027,7 @@ void Key_WriteBindings( fileHandle_t f ); void S_ClearSoundBuffer( void ); // call before filesystem access -void SCR_DebugGraph (float value, int color); // FIXME: move logging to common? +void SCR_DebugGraph (float value); // FIXME: move logging to common? // AVI files have the start of pixel lines 4 byte-aligned #define AVI_LINE_PADDING 4 @@ -1089,7 +1089,7 @@ void *Sys_GetBotLibAPI( void *parms ); char *Sys_GetCurrentUser( void ); -void QDECL Sys_Error( const char *error, ...) __attribute__ ((noreturn)) __attribute__ ((format (printf, 1, 2))); +void QDECL Sys_Error( const char *error, ...) __attribute__ ((noreturn, format (printf, 1, 2))); void Sys_Quit (void) __attribute__ ((noreturn)); char *Sys_GetClipboardData( void ); // note that this isn't journaled... diff --git a/reaction/code/qcommon/vm.c b/reaction/code/qcommon/vm.c index 292824d0..a99e109d 100644 --- a/reaction/code/qcommon/vm.c +++ b/reaction/code/qcommon/vm.c @@ -217,7 +217,6 @@ VM_LoadSymbols =============== */ void VM_LoadSymbols( vm_t *vm ) { - int len; union { char *c; void *v; @@ -239,7 +238,7 @@ void VM_LoadSymbols( vm_t *vm ) { COM_StripExtension(vm->name, name, sizeof(name)); Com_sprintf( symbols, sizeof( symbols ), "vm/%s.map", name ); - len = FS_ReadFile( symbols, &mapfile.v ); + FS_ReadFile( symbols, &mapfile.v ); if ( !mapfile.c ) { Com_Printf( "Couldn't load symbol file: %s\n", symbols ); return; @@ -365,7 +364,6 @@ Load a .qvm file ================= */ vmHeader_t *VM_LoadQVM( vm_t *vm, qboolean alloc ) { - int length; int dataLength; int i; char filename[MAX_QPATH]; @@ -378,7 +376,7 @@ vmHeader_t *VM_LoadQVM( vm_t *vm, qboolean alloc ) { Com_sprintf( filename, sizeof(filename), "vm/%s.qvm", vm->name ); Com_Printf( "Loading vm file %s...\n", filename ); - length = FS_ReadFileDir(filename, vm->searchPath, &header.v); + FS_ReadFileDir(filename, vm->searchPath, &header.v); if ( !header.h ) { Com_Printf( "Failed.\n" ); diff --git a/reaction/code/qcommon/vm_interpreted.c b/reaction/code/qcommon/vm_interpreted.c index 7ff0e16a..5eed5ed7 100644 --- a/reaction/code/qcommon/vm_interpreted.c +++ b/reaction/code/qcommon/vm_interpreted.c @@ -237,7 +237,6 @@ void VM_PrepareInterpreter( vm_t *vm, vmHeader_t *header ) { } int_pc = 0; instruction = 0; - code = (byte *)header + header->codeOffset; // Now that the code has been expanded to int-sized opcodes, we'll translate instruction index //into an index into codeBase[], which contains opcodes and operands. diff --git a/reaction/code/qcommon/vm_x86.c b/reaction/code/qcommon/vm_x86.c index aa63d048..da472082 100644 --- a/reaction/code/qcommon/vm_x86.c +++ b/reaction/code/qcommon/vm_x86.c @@ -1716,7 +1716,6 @@ int VM_CallCompiled(vm_t *vm, int *args) { byte stack[OPSTACK_SIZE + 15]; void *entryPoint; - int programCounter; int programStack, stackOnEntry; byte *image; int *opStack; @@ -1733,8 +1732,6 @@ int VM_CallCompiled(vm_t *vm, int *args) // set up the stack frame image = vm->dataBase; - programCounter = 0; - programStack -= 48; *(int *)&image[ programStack + 44] = args[9]; diff --git a/reaction/code/renderer/tr_backend.c b/reaction/code/renderer/tr_backend.c index 6f3b24fb..f93074c4 100644 --- a/reaction/code/renderer/tr_backend.c +++ b/reaction/code/renderer/tr_backend.c @@ -966,7 +966,7 @@ void RE_StretchRaw (int x, int y, int w, int h, int cols, int rows, const byte * // we definately want to sync every frame for the cinematics qglFinish(); - start = end = 0; + start = 0; if ( r_speeds->integer ) { start = ri.Milliseconds(); } diff --git a/reaction/code/renderer/tr_curve.c b/reaction/code/renderer/tr_curve.c index 784beb5f..d69f4146 100644 --- a/reaction/code/renderer/tr_curve.c +++ b/reaction/code/renderer/tr_curve.c @@ -204,10 +204,9 @@ static int neighbors[8][2] = { VectorAdd( normal, sum, sum ); count++; } - if ( count == 0 ) { -//printf("bad normal\n"); - count = 1; - } + //if ( count == 0 ) { + // printf("bad normal\n"); + //} VectorNormalize2( sum, dv->normal ); } } diff --git a/reaction/code/renderer/tr_flares.c b/reaction/code/renderer/tr_flares.c index 96b36aa9..ad01d868 100644 --- a/reaction/code/renderer/tr_flares.c +++ b/reaction/code/renderer/tr_flares.c @@ -114,7 +114,7 @@ This is called at surface tesselation time */ void RB_AddFlare( void *surface, int fogNum, vec3_t point, vec3_t color, vec3_t normal ) { int i; - flare_t *f, *oldest; + flare_t *f; vec3_t local; float d = 1; vec4_t eye, clip, normalized, window; @@ -152,7 +152,6 @@ void RB_AddFlare( void *surface, int fogNum, vec3_t point, vec3_t color, vec3_t } // see if a flare with a matching surface, scene, and view exists - oldest = r_flareStructs; for ( f = r_activeFlares ; f ; f = f->next ) { if ( f->surface == surface && f->frameSceneNum == backEnd.viewParms.frameSceneNum && f->inPortal == backEnd.viewParms.isPortal ) { diff --git a/reaction/code/renderer/tr_image.c b/reaction/code/renderer/tr_image.c index 37723ef5..241f8cb4 100644 --- a/reaction/code/renderer/tr_image.c +++ b/reaction/code/renderer/tr_image.c @@ -1497,14 +1497,11 @@ R_CreateFogImage static void R_CreateFogImage( void ) { int x,y; byte *data; - float g; float d; float borderColor[4]; data = ri.Hunk_AllocateTempMemory( FOG_S * FOG_T * 4 ); - g = 2.0; - // S is distance, T is depth for (x=0 ; x= 0 ) + if ( DotProduct( normal, tess.normal[tess.indexes[i]] ) >= 0 ) { numTriangles--; } @@ -1932,7 +1931,6 @@ static void R_AddEntitySurface (int entityNum) if ( (ent->e.renderfx & RF_THIRD_PERSON) && !tr.viewParms.isPortal) { break; } - shader = R_GetShaderByHandle( ent->e.customShader ); R_AddDrawSurf( &entitySurface, tr.defaultShader, 0, 0, 0 ); break; default: diff --git a/reaction/code/renderer/tr_marks.c b/reaction/code/renderer/tr_marks.c index b3c6c846..506ebdd9 100644 --- a/reaction/code/renderer/tr_marks.c +++ b/reaction/code/renderer/tr_marks.c @@ -275,6 +275,10 @@ int R_MarkFragments( int numPoints, const vec3_t *points, const vec3_t projectio vec3_t projectionDir; vec3_t v1, v2; + if (numPoints <= 0) { + return 0; + } + //increment view count for double check prevention tr.viewCount++; diff --git a/reaction/code/renderer/tr_model.c b/reaction/code/renderer/tr_model.c index 784b9134..d87d0b7c 100644 --- a/reaction/code/renderer/tr_model.c +++ b/reaction/code/renderer/tr_model.c @@ -1168,7 +1168,7 @@ static qboolean R_LoadMD4( model_t *mod, void *buffer, const char *mod_name ) { // swap all the frames frameSize = (size_t)( &((md4Frame_t *)0)->bones[ md4->numBones ] ); - for ( i = 0 ; i < md4->numFrames ; i++, frame++) { + for ( i = 0 ; i < md4->numFrames ; i++) { frame = (md4Frame_t *) ( (byte *)md4 + md4->ofsFrames + i * frameSize ); frame->radius = LittleFloat( frame->radius ); for ( j = 0 ; j < 3 ; j++ ) { diff --git a/reaction/code/renderer/tr_model_iqm.c b/reaction/code/renderer/tr_model_iqm.c index ad0012e8..f47d8ffd 100644 --- a/reaction/code/renderer/tr_model_iqm.c +++ b/reaction/code/renderer/tr_model_iqm.c @@ -885,8 +885,8 @@ static void ComputeJointMats( iqmData_t *data, int frame, int oldframe, int *joint = data->jointParents; int i; - if ( oldframe == frame ) { - mat1 = mat2 = data->poseMats + 12 * data->num_joints * frame; + if ( oldframe == frame ) { + mat1 = data->poseMats + 12 * data->num_joints * frame; for( i = 0; i < data->num_joints; i++, joint++ ) { if( *joint >= 0 ) { Matrix34Multiply( mat + 12 * *joint, diff --git a/reaction/code/renderer/tr_public.h b/reaction/code/renderer/tr_public.h index adda40a2..9b913375 100644 --- a/reaction/code/renderer/tr_public.h +++ b/reaction/code/renderer/tr_public.h @@ -109,7 +109,7 @@ typedef struct { void (QDECL *Printf)( int printLevel, const char *fmt, ...) __attribute__ ((format (printf, 2, 3))); // abort the game - void (QDECL *Error)( int errorLevel, const char *fmt, ...) __attribute__ ((format (printf, 2, 3))); + void (QDECL *Error)( int errorLevel, const char *fmt, ...) __attribute__ ((noreturn, format (printf, 2, 3))); // milliseconds should only be used for profiling, never // for anything game related. Get time from the refdef diff --git a/reaction/code/renderer/tr_shade.c b/reaction/code/renderer/tr_shade.c index f0ed8ef8..044331df 100644 --- a/reaction/code/renderer/tr_shade.c +++ b/reaction/code/renderer/tr_shade.c @@ -3047,8 +3047,10 @@ static void RB_RenderShadowmap( shaderCommands_t *input ) void RB_StageIteratorGeneric( void ) { shaderCommands_t *input; + shader_t *shader; input = &tess; + shader = input->shader; if (!input->numVertexes || !input->numIndexes) { @@ -3070,10 +3072,10 @@ void RB_StageIteratorGeneric( void ) // // set face culling appropriately // - GL_Cull( input->shader->cullType ); + GL_Cull( shader->cullType ); // set polygon offset if necessary - if ( input->shader->polygonOffset ) + if ( shader->polygonOffset ) { qglEnable( GL_POLYGON_OFFSET_FILL ); qglPolygonOffset( r_offsetFactor->value, r_offsetUnits->value ); @@ -3085,7 +3087,7 @@ void RB_StageIteratorGeneric( void ) // to avoid compiling those arrays since they will change // during multipass rendering // - if ( tess.numPasses > 1 || input->shader->multitextureEnv ) + if ( tess.numPasses > 1 || shader->multitextureEnv ) { setArraysOnce = qfalse; qglDisableClientState (GL_COLOR_ARRAY); @@ -3153,7 +3155,7 @@ void RB_StageIteratorGeneric( void ) // // reset polygon offset // - if ( input->shader->polygonOffset ) + if ( shader->polygonOffset ) { qglDisable( GL_POLYGON_OFFSET_FILL ); } @@ -3329,7 +3331,6 @@ void RB_StageIteratorVertexLitTexture( void ) } input = &tess; - shader = input->shader; // @@ -3350,7 +3351,7 @@ void RB_StageIteratorVertexLitTexture( void ) // // set face culling appropriately // - GL_Cull( input->shader->cullType ); + GL_Cull( shader->cullType ); // // set arrays and lock @@ -3404,6 +3405,7 @@ void RB_StageIteratorVertexLitTexture( void ) void RB_StageIteratorLightmappedMultitexture( void ) { shaderCommands_t *input; + shader_t *shader; if(glRefConfig.vertexBufferObject && r_arb_vertex_buffer_object->integer) { @@ -3413,6 +3415,7 @@ void RB_StageIteratorLightmappedMultitexture( void ) { } input = &tess; + shader = input->shader; // // log this call @@ -3426,7 +3429,7 @@ void RB_StageIteratorLightmappedMultitexture( void ) { // // set face culling appropriately // - GL_Cull( input->shader->cullType ); + GL_Cull( shader->cullType ); // // set color, pointers, and lock @@ -3516,8 +3519,10 @@ void RB_StageIteratorLightmappedMultitexture( void ) { */ void RB_EndSurface( void ) { shaderCommands_t *input; + shader_t *shader; input = &tess; + shader = input->shader; if (input->numIndexes == 0 || input->numVertexes == 0) { return; diff --git a/reaction/code/renderer/tr_shade_calc.c b/reaction/code/renderer/tr_shade_calc.c index 897696de..8299eff1 100644 --- a/reaction/code/renderer/tr_shade_calc.c +++ b/reaction/code/renderer/tr_shade_calc.c @@ -663,7 +663,7 @@ void RB_CalcColorFromOneMinusEntity( unsigned char *dstColors ) for ( i = 0; i < tess.numVertexes; i++, pColors++ ) { - *pColors = * ( int * ) invModulate; + *pColors = c; } } diff --git a/reaction/code/renderer/tr_sky.c b/reaction/code/renderer/tr_sky.c index 9f56adf2..fdad140e 100644 --- a/reaction/code/renderer/tr_sky.c +++ b/reaction/code/renderer/tr_sky.c @@ -720,14 +720,14 @@ void R_BuildCloudData( shaderCommands_t *input ) tess.numVertexes = 0; tess.firstIndex = 0; - if ( input->shader->sky.cloudHeight ) + if ( shader->sky.cloudHeight ) { for ( i = 0; i < MAX_SHADER_STAGES; i++ ) { if ( !tess.xstages[i] ) { break; } - FillCloudBox( input->shader, i ); + FillCloudBox( shader, i ); } } } diff --git a/reaction/code/renderer/tr_surface.c b/reaction/code/renderer/tr_surface.c index 0a87dd2a..77528070 100644 --- a/reaction/code/renderer/tr_surface.c +++ b/reaction/code/renderer/tr_surface.c @@ -1355,7 +1355,6 @@ static void RB_SurfaceGrid( srfGridMesh_t *srf ) { // in the tess structure, so we may have to issue it in multiple passes used = 0; - rows = 0; while ( used < lodHeight - 1 ) { // see how many rows of both verts and indexes we can add without overflowing do { diff --git a/reaction/code/server/sv_client.c b/reaction/code/server/sv_client.c index 7a609fb9..06be68e4 100644 --- a/reaction/code/server/sv_client.c +++ b/reaction/code/server/sv_client.c @@ -1213,7 +1213,6 @@ static void SV_VerifyPaks_f( client_t *cl ) { // if ( sv_pure->integer != 0 ) { - bGood = qtrue; nChkSum1 = nChkSum2 = 0; // we run the game, so determine which cgame and ui the client "should" be running bGood = (FS_FileIsInPAK("vm/cgame.qvm", &nChkSum1) == 1); diff --git a/reaction/code/server/sv_world.c b/reaction/code/server/sv_world.c index b2cec817..6861ef38 100644 --- a/reaction/code/server/sv_world.c +++ b/reaction/code/server/sv_world.c @@ -382,9 +382,6 @@ SV_AreaEntities_r static void SV_AreaEntities_r( worldSector_t *node, areaParms_t *ap ) { svEntity_t *check, *next; sharedEntity_t *gcheck; - int count; - - count = 0; for ( check = node->entities ; check ; check = next ) { next = check->nextEntityInWorldSector; @@ -680,7 +677,7 @@ int SV_PointContents( const vec3_t p, int passEntityNum ) { angles = vec3_origin; // boxes don't rotate } - c2 = CM_TransformedPointContents (p, clipHandle, hit->s.origin, hit->s.angles); + c2 = CM_TransformedPointContents (p, clipHandle, hit->s.origin, angles); contents |= c2; } diff --git a/reaction/code/sys/sys_unix.c b/reaction/code/sys/sys_unix.c index 653da2ec..0503581b 100644 --- a/reaction/code/sys/sys_unix.c +++ b/reaction/code/sys/sys_unix.c @@ -405,9 +405,9 @@ char **Sys_ListFiles( const char *directory, const char *extension, char *filter continue; if (*extension) { - if ( strlen( d->d_name ) < strlen( extension ) || + if ( strlen( d->d_name ) < extLen || Q_stricmp( - d->d_name + strlen( d->d_name ) - strlen( extension ), + d->d_name + strlen( d->d_name ) - extLen, extension ) ) { continue; // didn't match }