qf
/
quakeforge
mirror of https://git.code.sf.net/p/quake/quakeforge
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[quakefs] Clean out some excess memsets 

There's no point in zeroing out memory that is only going to be
overwritten by the loaded file (excess bytes beyond the end of a
massaged text file shouldn't be accessed anyway, and the terminating
null is still written).
This commit is contained in:
Bill Currie 2021-12-13 09:15:51 +09:00
parent 2086125e0b
commit fde47d6983
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libs/util/quakefs.c
View File

@ -1142,11 +1142,11 @@ QFS_LoadFile (QFile *file, int usehunk)
//base = QFS_FileBase (path);
if (usehunk == 1)
buf = Hunk_AllocName (0, len + 1, base);
buf = Hunk_RawAllocName (qfs_hunk, len + 1, base);
else if (usehunk == 2)
buf = Hunk_TempAlloc (0, len + 1);
buf = Hunk_TempAlloc (qfs_hunk, len + 1);
else if (usehunk == 0)
buf = calloc (1, len + 1);
buf = malloc (len + 1);
else if (usehunk == 3)
buf = Cache_Alloc (loadcache, len + 1, base);
else
@ -1156,8 +1156,8 @@ QFS_LoadFile (QFile *file, int usehunk)
Sys_Error ("QFS_LoadFile: not enough space");
//Sys_Error ("QFS_LoadFile: not enough space for %s", path);
len = Qread (file, buf, len);
buf[len] = 0;
Qread (file, buf, len);
Qclose (file);
free (base);