qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-02-25 05:01:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

[ui] Free any preexisting passage glyphs

Browse source 
This plugs a memory leak in Text_PassageView.
This commit is contained in:
Bill Currie 2023-12-28 16:40:26 +09:00
parent dc8ee14f50
commit f4f81db440
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
libs/ui/text.c
View file

@ -313,6 +313,14 @@ Text_PassageView (text_system_t textsys, font_t *font, passage_t *passage)
.glyphs = glyphs, .glyphs = glyphs,
.count = glyph_count, .count = glyph_count,
}; };
if (Ent_HasComponent (passage_view.id, c_passage_glyphs, reg)) {
// free the glyphs directly to avoid unnecessary motion in the
// component pool (more for order preservation than it being overly
// expensive);
glyphset_t *gs = Ent_GetComponent (passage_view.id, c_passage_glyphs,
reg);
free (gs->glyphs);
}
Ent_SetComponent (passage_view.id, c_passage_glyphs, reg, &glyphset); Ent_SetComponent (passage_view.id, c_passage_glyphs, reg, &glyphset);
hb_buffer_destroy (buffer); hb_buffer_destroy (buffer);
hb_font_destroy (fnt); hb_font_destroy (fnt);