qfcc.h:

o	add a "freed" marker to def_t to prevent double freeing of
		temp def offsets
emit.c:
	o	break out the bind code into emit_bind_expr (doesn't /really/
		emit code, but still:)
	o	make bind work with disparate types (forces def_t->freed 1)
pr_def.c:
	o	mark array pointers as initialized and constant.
	o	don't free the offset for already freed temp defs
pr_imm.c
	o	fix a bug in uinteger support
	o	support disparate types for immediates
switch:
	o	fix a bug where gt.i was being used instead of gt.ui
	o	remove some debug code

tools/qfcc/include/qfcc.h

@@ -292,6 +292,7 @@ typedef struct def_s {
 	int				constant;	// 1 when a declaration included "= immediate"
 	statref_t		*refs;			// for relocations
 
+	int				freed;			// already freed from the scope
 	int				removed;		// already removed from the symbol table
 	int				used;			// unused local detection
 	string_t		file;			// source file

tools/qfcc/source/emit.c

@@ -194,6 +194,29 @@ emit_assign_expr (expr_t *e)
 	return def_b;
 }
 
+def_t *
+emit_bind_expr (expr_t *e1, expr_t *e2)
+{
+	type_t     *t1 = get_type (e1);
+	type_t     *t2 = get_type (e2);
+	def_t      *def;
+
+	if (!e2 || e2->type != ex_temp) {
+		error (e1, "internal error");
+		abort ();
+	}
+	def = emit_sub_expr (e1, e2->e.temp.def);
+	if (t1 != t2) {
+		def_t      *tmp = PR_NewDef (t2, 0, def->scope);
+		tmp->ofs = def->ofs;
+		tmp->users = e2->e.temp.users;
+		tmp->freed = 1;			// don't free this offset when freeing def
+		def = tmp;
+	}
+	e2->e.temp.def = def;
+	return e2->e.temp.def;
+}
+
 def_t *
 emit_sub_expr (expr_t *e, def_t *dest)
 {
@@ -364,11 +387,7 @@ emit_expr (expr_t *e)
 					emit_statement (e->line, op_state, def_a, def_b, 0);
 					break;
 				case 'b':
-					if (!e->e.expr.e2 || e->e.expr.e2->type != ex_temp) {
-						error (e, "internal error");
-						abort ();
-					}
-					e->e.expr.e2->e.temp.def = emit_sub_expr (e->e.expr.e1, e->e.expr.e2->e.temp.def);
+					emit_bind_expr (e->e.expr.e1, e->e.expr.e2);
 					break;
 				case 'g':
 					def_a = emit_sub_expr (e->e.expr.e1, 0);

tools/qfcc/source/pr_def.c

@@ -93,6 +93,7 @@ PR_GetArray (type_t *etype, const char *name, int size, def_t *scope,
 		return def;
 	def = PR_NewDef (type, name, scope);
 	def->ofs = *allocate;
+	def->initialized = def->constant = 1;
 	*allocate += pr_type_size [type->type] * size + 1;
 	pr_global_defs[def->ofs] = def;
 	G_INT (def->ofs) = def->ofs + 1;
@@ -281,8 +282,11 @@ PR_FreeTempDefs (void)
 			if (d->expr)
 				d->expr->e.temp.def = 0;
 
-			d->next = free_temps[size];
-			free_temps[size] = d;
+			if (!d->freed) {
+				d->next = free_temps[size];
+				free_temps[size] = d;
+				d->freed = 1;
+			}
 		} else {
 			def = &(*def)->next;
 		}

tools/qfcc/source/pr_imm.c

@@ -136,7 +136,10 @@ PR_ReuseConstant (expr_t *expr, def_t *def)
 			if (!def || def->type != &type_float) {
 				sprintf (rep, "\001integer:%08X\001", e.e.integer_val);
 				tab = integer_imm_defs;
-				type = &type_integer;
+				if (e.type == ex_uinteger)
+					type = &type_uinteger;
+				else
+					type = &type_integer;
 				break;
 			}
 			if (e.type == ex_uinteger)
@@ -186,7 +189,12 @@ PR_ReuseConstant (expr_t *expr, def_t *def)
 	// allocate a new one
 	// always share immediates
 	if (def) {
-		cn = def;
+		if (def->type != type) {
+			cn = PR_NewDef (type, ".imm", 0);
+			cn->ofs = def->ofs;
+		} else {
+			cn = def;
+		}
 	} else {
 		cn = PR_NewDef (type, ".imm", 0);
 		cn->ofs = PR_NewLocation (type);

tools/qfcc/source/switch.c

@@ -255,7 +255,6 @@ build_switch (expr_t *sw, case_node_t  *tree, int op, expr_t *sw_val,
 	test->file = sw_val->file;
 
 	if (tree->low == tree->high) {
-		printf ("%3d\n", tree->low->e.integer_val);
 		branch = new_binary_expr ('n', test, tree->labels[0]);
 		branch->line = sw_val->line;
 		branch->file = sw_val->file;
@@ -284,7 +283,7 @@ build_switch (expr_t *sw, case_node_t  *tree, int op, expr_t *sw_val,
 		int         i;
 		expr_t     *range = binary_expr ('-', tree->high, tree->low);
 
-		printf ("%3d %3d\n", low, high);
+		range->type = ex_uinteger;
 
 		def = PR_GetArray (&type_uinteger, name, high - low + 1, 0,
 						   &numpr_globals);
@@ -299,7 +298,6 @@ build_switch (expr_t *sw, case_node_t  *tree, int op, expr_t *sw_val,
 			branch->file = sw_val->file;
 			append_expr (sw, branch);
 		}
-		tree->high->type = ex_uinteger;
 		append_expr (sw, new_binary_expr ('b', temp, utemp));
 		test = binary_expr (GT, utemp, range);
 		test->line = sw_val->line;