qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-03-21 01:41:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

[util] Deal with gcc optimizing out isnan checks

Browse source 
This occurs because of -ffast-math, but I need to investigate how much
of an impact disabling it has on QF's performance.
This commit is contained in:
Bill Currie 2020-12-21 02:32:29 +09:00
parent ab04a1915e
commit ebcef5c8a4
1 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
libs/util/test/test-quat.c
View file

@ -239,11 +239,16 @@ fail:
return 0;
}
// XXX FIXME see usage in test_rotation4. need to investigate whether
// -ffast-math is any real benefit
#define ISNAN(x) (((x) & 0x7f800000) == 0x7f800000 && ((x) & 0x7fffff))
static int
test_rotation4 (const vec3_t a, const vec3_t b, const quat_t expect)
{
int i;
quat_t quat;
union { int x[4]; vec_t q[4]; } q;
vec_t *quat = q.q;
vec3_t t;
vec_t d = 0;
@ -258,13 +263,19 @@ test_rotation4 (const vec3_t a, const vec3_t b, const quat_t expect)
}
// expect NaN for the vector components because the vectors are
// anti-parallel and thus the rotation axis is undefined
if (!(isnan(quat[0]) && isnan(quat[1]) && isnan(quat[2]))) {
//XXX FIXME(?) still using -ffast-math which implies
// -ffinite-math-only which in turn disables nan/inf checks, so have
// to do it by hand
// if (!(isnan(quat[0]) && isnan(quat[1]) && isnan(quat[2]))) {
if (!(ISNAN(q.x[0]) && ISNAN(q.x[1]) && ISNAN(q.x[2]))) {
goto fail;
}
} else {
// the vectors are not anti-parallel and thus the rotation axis is
// defined, so NaN is invalid
if (isnan(quat[0]) || isnan(quat[1]) || isnan(quat[2])) {
// XXX FIXME see above
//if (isnan(quat[0]) || isnan(quat[1]) || isnan(quat[2])) {
if (ISNAN(q.x[0]) || ISNAN(q.x[1]) || ISNAN(q.x[2])) {
goto fail;
}
for (i = 0; i < 4; i++) {
@ -288,6 +299,7 @@ fail:
printf ("%11.9g %11.9g %11.9g\n", VectorExpand(a));
printf ("%11.9g %11.9g %11.9g\n", VectorExpand(b));
printf ("%11.9g %11.9g %11.9g %11.9g\n", QuatExpand(quat));
printf ("%11.9g %11.9g %11.9g %11.9g\n", QuatExpand(expect));
printf ("%11.9g %11.9g %11.9g\n", VectorExpand(t));
printf ("%11.9g\n", d);
return 0;