qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-01-17 22:50:51 +00:00
Code Issues Projects Releases Packages Wiki Activity

make file open a little more secure

Browse source
This commit is contained in:
Bill Currie 2002-03-11 19:01:13 +00:00
parent 87e4148ffc
commit d5fe4e3130
1 changed files with 85 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

85
libs/gamecode/builtins/bi_file.c
View file

@ -38,6 +38,8 @@ static const char rcsid[] =
# include <strings.h> # include <strings.h>
#endif #endif
#include "fnmatch.h"
#include "QF/progs.h" #include "QF/progs.h"
#include "QF/va.h" #include "QF/va.h"
#include "QF/vfs.h" #include "QF/vfs.h"
@ -46,6 +48,60 @@ static const char rcsid[] =
#define MAX_HANDLES 20 #define MAX_HANDLES 20
static VFile *handles[MAX_HANDLES]; static VFile *handles[MAX_HANDLES];
static const char *file_ban_list[] = {
"default.cfg{,.gz}",
"demo1.dem{,.gz}",
"demo2.dem{,.gz}",
"demo3.dem{,.gz}",
"end1.bin{,.gz}",
"end2.bin{,.gz}",
"gfx.wad{,.gz}",
"progs.dat{,.gz}",
"quake.rc{,.gz}",
0,
};
static const char *dir_ban_list[] = {
"gfx",
"maps",
"progs",
"skins",
"sound",
0,
};
static int
file_readable (char *path)
{
char t;
char *p = strchr (path, '/');
const char **match;
if (p) {
t = *p;
*p = 0;
for (match = dir_ban_list; *match; match++) {
if (fnmatch (*match, path, FNM_PATHNAME) == 0) {
*p = t;
return 0;
}
}
} else {
for (match = file_ban_list; *match; match++) {
if (fnmatch (*match, path, FNM_PATHNAME) == 0) {
return 0;
}
}
}
return 1;
}
static int
file_writeable (char *path)
{
return file_readable (path);
}
static void static void
bi_File_Open (progs_t *pr) bi_File_Open (progs_t *pr)
{ {
@ -54,6 +110,29 @@ bi_File_Open (progs_t *pr)
char *path= Hunk_TempAlloc (strlen (pth) + 1); char *path= Hunk_TempAlloc (strlen (pth) + 1);
char *p, *d; char *p, *d;
int h; int h;
int do_write = 0;
int do_read = 0;
p = strchr (mode, 'r');
if (p) {
do_read |= 1;
if (p[1] == '+')
do_write |= 1;
}
p = strchr (mode, 'w');
if (p) {
do_write |= 1;
if (p[1] == '+')
do_read |= 1;
}
p = strchr (mode, 'a');
if (p) {
do_write |= 1;
if (p[1] == '+')
do_read |= 1;
}
for (d = path; *pth; d++, pth++) { for (d = path; *pth; d++, pth++) {
if (*pth == '\\') if (*pth == '\\')
@ -101,6 +180,12 @@ bi_File_Open (progs_t *pr)
goto error; goto error;
if (path[strlen (path) - 1] =='/') if (path[strlen (path) - 1] =='/')
goto error; goto error;
if (!do_read && !do_write)
goto error;
if (do_read && !file_readable (path))
goto error;
if (do_write && !file_writeable (path))
goto error;
for (h = 0; h < MAX_HANDLES && handles[h]; h++) for (h = 0; h < MAX_HANDLES && handles[h]; h++)
; ;
if (h == MAX_HANDLES) if (h == MAX_HANDLES)