From d4c78a69f4fb2c463c965c37e205db5ce0aaa24a Mon Sep 17 00:00:00 2001 From: Bill Currie Date: Sun, 15 Sep 2024 15:02:36 +0900 Subject: [PATCH] [qfcc] Fix uninitialized zero in component_compare It was a bit of a surprise seeing a test case fail and then succeed after making a minor edit to help find the bug, but valgrind to the rescue. I'm surprised nothing showed up earlier. --- tools/qfcc/source/expr_algebra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/qfcc/source/expr_algebra.c b/tools/qfcc/source/expr_algebra.c index 22b213a44..d1098160c 100644 --- a/tools/qfcc/source/expr_algebra.c +++ b/tools/qfcc/source/expr_algebra.c @@ -2676,7 +2676,7 @@ component_compare (int op, const expr_t *e1, const expr_t *e2, algebra_t *alg) auto t = get_type (e1 ? e1 : e2); auto stype = alg->type; auto vtype = vector_type (stype, type_width (t)); - pr_type_t zero[type_size (vtype)]; + pr_type_t zero[type_size (vtype)] = {}; if (!e1) { e1 = new_value_expr (new_type_value (vtype, zero), false); } else {