qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-04-04 00:10:52 +00:00
Code Issues Projects Releases Packages Wiki Activity

[qfcc] Fix uninitialized zero in component_compare

Browse source 
It was a bit of a surprise seeing a test case fail and then succeed
after making a minor edit to help find the bug, but valgrind to the
rescue. I'm surprised nothing showed up earlier.
This commit is contained in:
Bill Currie 2024-09-15 15:02:36 +09:00
parent 9cd8bc0d45
commit d4c78a69f4
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/qfcc/source/expr_algebra.c
View file

@ -2676,7 +2676,7 @@ component_compare (int op, const expr_t *e1, const expr_t *e2, algebra_t *alg)
auto t = get_type (e1 ? e1 : e2);
auto stype = alg->type;
auto vtype = vector_type (stype, type_width (t));
pr_type_t zero[type_size (vtype)];
pr_type_t zero[type_size (vtype)] = {};
if (!e1) {
e1 = new_value_expr (new_type_value (vtype, zero), false);
} else {