qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-04-08 18:31:59 +00:00
Code Issues Projects Releases Packages Wiki Activity

[qfprogs] Use a backup type array for qcc progs

Browse source 
I was investigating how qcc dealt with field fields and got segfaults
from qfprogs due to the lack of type encodings. While the resulting
output is not guaranteed to be correct (especially if trying to dump
progs compiled by some other extended compiler), at least it's better
than segfaulting or any other UB.
This commit is contained in:
Bill Currie 2024-08-17 15:16:09 +09:00
parent 9eb6aba02c
commit cdf49bb6b7
1 changed files with 21 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
tools/qfcc/source/dump_globals.c
View file

@ -49,6 +49,17 @@
#include "tools/qfcc/include/reloc.h"
#include "tools/qfcc/include/strpool.h"
//This is a bit of a hack, but currently, the debug view functions do not
//try to do anything with field/pointer/function types other than determine
//that the def is one of those types, but it allows globals dumping to work
//with progs that don't have qfcc's type encodings, in particular, anything
//compiled using qcc.
#define EV_TYPE(t) { .meta = ty_basic, .type = ev_##t },
static qfot_type_t basic_types[] = {
#include "QF/progs/pr_type_names.h"
{ .meta = ty_basic, .type = ev_invalid },
};
static int
cmp (const void *_a, const void *_b)
{
@ -84,6 +95,16 @@ dump_def (progs_t *pr, pr_def_t *def, int indent)
}
dstring_clearstr (value_dstr);
qfot_type_t *ty = &G_STRUCT (pr, qfot_type_t, def->type_encoding);
if (!ty) {
//FIXME Rather iffy for any progs with extended types, but better
//than segfaulting
etype_t t = def->type & ~DEF_SAVEGLOBAL;
if (t < ev_invalid) {
ty = &basic_types[t];
} else {
ty = &basic_types[ev_invalid];
}
}
comment = PR_Debug_ValueString (pr, offset, ty, value_dstr);
}
printf ("%*s %x:%d %d %s %s:%x %s\n", indent * 12, "",