qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2024-11-22 20:41:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

[qfcc] Use operand_address in expr_deref

Browse source 
This fixes the technically correct but horrible mess of temps and
addressing when dealing with ivars, and the resulting uninitialized
temps due to the non-constant pointers (do need statement level constant
folding, though).
This commit is contained in:
Bill Currie 2020-03-16 12:25:28 +09:00
parent b58deb5680
commit c8e45c6cfc
1 changed files with 2 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
tools/qfcc/source/statements.c
View file

@ -966,7 +966,6 @@ expr_call (sblock_t *sblock, expr_t *call, operand_t **op)
continue;
}
if (is_struct (get_type (param))) {
//FIXME this should be done in the expression tree
expr_t *mov = assign_expr (param, a);
mov->line = a->line;
mov->file = a->file;
@ -1010,15 +1009,6 @@ lea_statement (operand_t *pointer, operand_t *offset, expr_t *e)
return s;
}
static statement_t *
address_statement (operand_t *value, expr_t *e)
{
statement_t *s = new_statement (st_expr, "&", e);
s->opa = value;
s->opc = temp_operand (&type_pointer, e);
return s;
}
static sblock_t *
expr_deref (sblock_t *sblock, expr_t *deref, operand_t **op)
{
@ -1047,13 +1037,11 @@ expr_deref (sblock_t *sblock, expr_t *deref, operand_t **op)
src_addr = s->opc;
sblock_add_statement (sblock, s);
//FIXME an address immediate would be nice.
s = address_statement (*op, e);
dst_addr = s->opc;
sblock_add_statement (sblock, s);
dst_addr = operand_address (*op, e);
s = new_statement (st_move, "<MOVEP>", deref);
s->opa = src_addr;
//FIXME large types
s->opb = short_operand (type_size (type), e);
s->opc = dst_addr;
sblock_add_statement (sblock, s);