qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2024-11-26 22:31:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

clean up a fixme. this doesn't fix serplord's out-of-bounds problem, but

Browse source 
that's because his qc compiler is doing weird stuff.
This commit is contained in:
Bill Currie 2002-02-11 19:36:36 +00:00
parent d47533ad2e
commit b5c2c0e14e
1 changed files with 20 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
libs/gamecode/engine/pr_opcode.c
View file

@ -304,23 +304,28 @@ static inline void
check_global (progs_t *pr, dstatement_t *st, opcode_t *op, etype_t type,
unsigned short operand)
{
const char *msg;
switch (type) {
case ev_short:
break;
case ev_void:
//FIXME need better "not used flags"
if (operand && st->op != OP_RETURN && st->op != OP_DONE)
PR_Error (pr, "PR_Check_Opcodes: non-zero global index in "
"void operand (statement %ld: %s)\n",
(long)(st - pr->pr_statements), op->opname);
if (operand) {
msg = "non-zero global index in void operand";
goto error;
}
break;
default:
if (operand >= pr->progs->numglobals)
PR_Error (pr, "PR_Check_Opcodes: out of bounds global index "
"(statement %ld: %s)\n",
(long)(st - pr->pr_statements), op->opname);
if (operand >= pr->progs->numglobals) {
msg = "out of bounds global index";
goto error;
}
break;
}
return;
error:
PR_Error (pr, "PR_Check_Opcodes: %s (statement %ld: %s)\n", msg,
(long)(st - pr->pr_statements), op->opname);
}
void
@ -349,6 +354,12 @@ PR_Check_Opcodes (progs_t *pr)
case OP_GOTO:
check_branch (pr, st, op, st->a);
break;
case OP_DONE:
case OP_RETURN:
check_global (pr, st, op, ev_integer, st->a);
check_global (pr, st, op, ev_void, st->b);
check_global (pr, st, op, ev_void, st->c);
break;
default:
check_global (pr, st, op, op->type_a, st->a);
check_global (pr, st, op, op->type_b, st->b);