From ae5dbdb7fb8d11461201fe135a94878f584aceae Mon Sep 17 00:00:00 2001
From: Bill Currie <bill@taniwha.org>
Date: Tue, 7 Mar 2023 13:17:46 +0900
Subject: [PATCH] [qfcc] Add failing test for function/array pointers

It turns out I broke the type system when it comes to pointers to
functions and arrays. This test checks basic function and array pointers
and passes with qfcc from before the type system rework.
---
 tools/qfcc/test/Makemodule.am | 11 ++++++
 tools/qfcc/test/ptrfunc.r     | 72 +++++++++++++++++++++++++++++++++++
 2 files changed, 83 insertions(+)
 create mode 100644 tools/qfcc/test/ptrfunc.r

diff --git a/tools/qfcc/test/Makemodule.am b/tools/qfcc/test/Makemodule.am
index ea2ba9f70..faf0eb9bb 100644
--- a/tools/qfcc/test/Makemodule.am
+++ b/tools/qfcc/test/Makemodule.am
@@ -42,6 +42,7 @@ test_progs_dat=\
 	tools/qfcc/test/paramret.dat \
 	tools/qfcc/test/postop.dat \
 	tools/qfcc/test/ptraliasenc.dat \
+	tools/qfcc/test/ptrfunc.dat \
 	tools/qfcc/test/ptrstructcast.dat \
 	tools/qfcc/test/quaternion.dat \
 	tools/qfcc/test/return-ivar.dat \
@@ -517,6 +518,16 @@ tools/qfcc/test/ptraliasenc.run: $(qfcc_test_run_deps)
 include $(ptraliasenc_dep) # am--include-marker
 r_depfiles_remade += $(ptraliasenc_dep)
 
+tools_qfcc_test_ptrfunc_dat_SOURCES=tools/qfcc/test/ptrfunc.r
+ptrfunc_obj=$(tools_qfcc_test_ptrfunc_dat_SOURCES:.r=.o)
+ptrfunc_dep=$(call qcautodep,$(tools_qfcc_test_ptrfunc_dat_SOURCES))
+tools/qfcc/test/ptrfunc.dat$(EXEEXT): $(ptrfunc_obj) $(QFCC_DEP)
+	$(V_QFCCLD)$(QLINK) -o $@ $(ptrfunc_obj)
+tools/qfcc/test/ptrfunc.run: $(qfcc_test_run_deps)
+	@$(top_srcdir)/tools/qfcc/test/build-run $@
+include $(ptrfunc_dep) # am--include-marker
+r_depfiles_remade += $(ptrfunc_dep)
+
 tools_qfcc_test_ptrstructcast_dat_SOURCES=tools/qfcc/test/ptrstructcast.r
 ptrstructcast_obj=$(tools_qfcc_test_ptrstructcast_dat_SOURCES:.r=.o)
 ptrstructcast_dep=$(call qcautodep,$(tools_qfcc_test_ptrstructcast_dat_SOURCES))
diff --git a/tools/qfcc/test/ptrfunc.r b/tools/qfcc/test/ptrfunc.r
new file mode 100644
index 000000000..12d4a77c7
--- /dev/null
+++ b/tools/qfcc/test/ptrfunc.r
@@ -0,0 +1,72 @@
+int func(string x) { return 1; }
+int (*funcptr)(string);
+int *(*ptrfuncptr)(string);
+int array[7];
+int *ptrarray[7];
+int (*arrayptr)[7];
+int *(*ptrarrayptr)[7];
+
+#include <types.h>
+
+#include "test-harness.h"
+
+typedef struct xdef_s {
+	qfot_type_t *type;			///< pointer to type definition
+	void       *ofs;			///< 32-bit version of ddef_t.ofs
+} xdef_t;
+
+typedef struct xdefs_s {
+	xdef_t     *xdefs;
+	unsigned    num_xdefs;
+} xdefs_t;
+
+void *PR_FindGlobal (string name) = #0;
+
+xdef_t *
+find_xdef (void *varaddr)
+{
+	//FIXME need a simple way to get at a def's meta-data
+	xdefs_t    *xdefs = PR_FindGlobal (".xdefs");
+	xdef_t     *xdef = xdefs.xdefs;
+	while (xdef - xdefs.xdefs < xdefs.num_xdefs && xdef.ofs != varaddr) {
+		xdef++;
+	}
+	if (xdef.ofs != varaddr) {
+		return nil;
+	}
+	return xdef;
+}
+
+int
+check_var (string name, string encoding)
+{
+	void       *var = PR_FindGlobal (name);
+	if (!var) {
+		printf ("could not find var: %s\n", name);
+		return 0;
+	}
+	xdef_t     *xdef = find_xdef (var);
+	if (!var) {
+		printf ("could not find xdef var: %s @ %p\n", name, var);
+		return 0;
+	}
+	int         ok = xdef.type.encoding == encoding;
+	printf ("%s: %p %s %s %s\n", name, var, xdef.type.encoding, encoding,
+			ok ? "pass" : "fail");
+	return ok;
+}
+
+int
+main (void)
+{
+	int         ok = 1;
+	ok &= check_var ("PR_FindGlobal", "(^v*)");
+	ok &= check_var ("func", "(i*)");
+	ok &= check_var ("funcptr", "^(i*)");
+	ok &= check_var ("ptrfuncptr", "^(^i*)");
+	ok &= check_var ("array", "[7=i]");
+	ok &= check_var ("ptrarray", "[7=^i]");
+	ok &= check_var ("arrayptr", "^[7=i]");
+	ok &= check_var ("ptrarrayptr", "^[7=^i]");
+	return 1 & (!ok);
+}