qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2024-11-10 15:22:04 +00:00
Code Issues Projects Releases Packages Wiki Activity

Grievre's skin DoS fix

Browse source
This commit is contained in:
Bill Currie 2004-04-04 02:34:05 +00:00
parent c2d633bf69
commit ab52e74874
2 changed files with 11 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
include/QF/skin.h
View file

@ -33,13 +33,14 @@
#include "QF/zone.h" #include "QF/zone.h"
#define MAX_CACHED_SKINS 128 #define MAX_CACHED_SKINS 128
#define MAX_SKIN_LENGTH 32
#define RSSHOT_WIDTH 320 #define RSSHOT_WIDTH 320
#define RSSHOT_HEIGHT 200 #define RSSHOT_HEIGHT 200
typedef struct skin_s typedef struct skin_s
{ {
char name[16]; char name[MAX_SKIN_LENGTH];
qboolean failedload; // the name isn't a valid skin qboolean failedload; // the name isn't a valid skin
union { union {
cache_user_t cache; cache_user_t cache;

13
qw/source/cl_parse.c
View file

@ -977,14 +977,19 @@ CL_ParseClientdata (void)
static void static void
CL_ProcessUserInfo (int slot, player_info_t *player) CL_ProcessUserInfo (int slot, player_info_t *player)
{ {
char *skin; char skin[MAX_SKIN_LENGTH] = { 0 };
const char *s; const char *s;
s = Info_ValueForKey (player->userinfo, "skin"); s = Info_ValueForKey (player->userinfo, "skin");
skin = alloca (strlen (s) + 1);
QFS_StripExtension (s, skin); if (strlen(s) < sizeof skin) {
if (!strequal (s, skin)) QFS_StripExtension (s, skin);
if (!strequal (s, skin))
Info_SetValueForKey (player->userinfo, "skin", skin, 1);
} else {
Info_SetValueForKey (player->userinfo, "skin", skin, 1); Info_SetValueForKey (player->userinfo, "skin", skin, 1);
}
s = Info_ValueForKey (player->userinfo, "name"); s = Info_ValueForKey (player->userinfo, "name");
if (!*s) if (!*s)
Info_SetValueForKey (player->userinfo, "name", va ("user-%i [exploit]", player->userid), 1); Info_SetValueForKey (player->userinfo, "name", va ("user-%i [exploit]", player->userid), 1);