qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2024-11-10 23:32:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

[scene] Return existing component instead of null

Browse source 
While checking on how Ent_AddComponent behaved (I don't remember what I
was looking for, though), I realized that instead of treating adding the
same component to an entity as an error, Ent_AddComponent should just
return the existing component.
This commit is contained in:
Bill Currie 2022-10-25 09:50:14 +09:00
parent f37c31a2dc
commit 9e83ded0ac
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
libs/scene/component.c
View file

@ -68,15 +68,14 @@ ECS_RegisterComponents (ecs_registry_t *registry,
}
}
VISIBLE void*
VISIBLE void *
Ent_AddComponent (uint32_t ent, uint32_t comp, ecs_registry_t *registry)
{
uint32_t id = Ent_Index (ent);
ecs_pool_t *pool = &registry->comp_pools[comp];
if (pool->sparse[id] < pool->count) {
//Sys_Error ("Ent_AddComponent: component %s already on entity %x\n",
// registry->components[i].name, ent);
return 0;
if (pool->sparse[id] < pool->count
&& pool->dense[pool->sparse[id]] == ent) {
return Ent_GetComponent (ent, comp, registry);
}
if (pool->count == pool->max_count) {
pool->max_count += COMP_GROW;