qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-02-24 20:51:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

[qfcc] Be more cautious with summed extents

Browse source 
They should be treated as such only when merging vector components. This
fixes a bug that doesn't actually exist (it's in experimental code),
where the sum of two 3-component vectors was getting lost.
This commit is contained in:
Bill Currie 2023-09-25 23:40:35 +09:00
parent c01cbf4fc4
commit 9c258b02e8
1 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
tools/qfcc/source/expr_algebra.c
View file

@ -2420,9 +2420,22 @@ find_offset (const type_t *t1, const type_t *t2)
static bool __attribute__((const))
summed_extend (const expr_t *e)
{
return (e->type == ex_expr && e->expr.op == '+'
&& e->expr.e1->type == ex_extend
&& e->expr.e2->type == ex_extend);
if (!(e->type == ex_expr && e->expr.op == '+'
&& e->expr.e1->type == ex_extend
&& e->expr.e2->type == ex_extend)) {
return false;
}
auto ext1 = e->expr.e1->extend;
auto ext2 = e->expr.e2->extend;
pr_uint_t bits1 = (1 << type_width (get_type (ext1.src))) - 1;
pr_uint_t bits2 = (1 << type_width (get_type (ext2.src))) - 1;
if (ext1.reverse) {
bits1 <<= type_width (ext1.type) - type_width (get_type (ext1.src));
}
if (ext2.reverse) {
bits2 <<= type_width (ext2.type) - type_width (get_type (ext2.src));
}
return !(bits1 & bits2);
}
static void