qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-01-18 23:11:38 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix uninitialized data

Browse source 
In the process of testing the changes to WriteBSPFile, it was found that
the data being supplied to it contained uninitialized values.
This commit is contained in:
Bill Currie 2010-08-22 22:32:16 +09:00
parent 1d86e71404
commit 99d8ea22b4
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
tools/qfbsp/source/writebsp.c
View file

@ -187,6 +187,8 @@ WriteLeaf (node_t *node)
}
leaf_p.nummarksurfaces = bsp->nummarksurfaces - leaf_p.firstmarksurface;
memset (leaf_p.ambient_level, 0, sizeof (leaf_p.ambient_level));
BSP_AddLeaf (bsp, &leaf_p);
}
@ -244,6 +246,8 @@ WriteDrawNodes (node_t *headnode)
Sys_Error ("nummodels == MAX_MAP_MODELS");
bm.headnode[0] = bsp->numnodes;
for (i = 1; i < MAX_MAP_HULLS; i++)
bm.headnode[i] = 0;
bm.firstface = firstface;
bm.numfaces = bsp->numfaces - firstface;
firstface = bsp->numfaces;
@ -260,6 +264,7 @@ WriteDrawNodes (node_t *headnode)
bm.mins[i] = headnode->mins[i] + SIDESPACE + 1; // remove the padding
bm.maxs[i] = headnode->maxs[i] - SIDESPACE - 1;
}
VectorZero (bm.origin);
BSP_AddModel (bsp, &bm);
// FIXME: are all the children decendant of padded nodes?
}