qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2025-02-24 20:51:35 +00:00
Code Issues Projects Releases Packages Wiki Activity

[qfcc] Do initializer type checking in declare_symbol

Browse source 
This is a nice common place (all languages and targets use it) for the
warning and any conversions, though those are still spread in various
places (and need to be cleaned up), so it doesn't do all that much yet.
This commit is contained in:
Bill Currie 2025-01-20 12:30:18 +09:00
parent 133156fdc7
commit 97a0763766
1 changed files with 36 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
tools/qfcc/source/symtab.c
View file

@ -277,6 +277,27 @@ shadows_param (symbol_t *sym, symtab_t *symtab)
return false;
}
static bool
init_type_ok (const type_t *dstType, const expr_t *init)
{
auto init_type = get_type (init);
if (init->implicit || type_promotes (dstType, init_type)) {
return true;
}
if (is_pointer (dstType) && is_pointer (init_type)) {
return true;
}
if (is_math (dstType) && !is_scalar (dstType)) {
// vector or matrix type
return true;
}
if (is_integral (dstType) && is_integral (init_type)
&& (type_size (dstType) == type_size (init_type))) {
return true;
}
return false;
}
symbol_t *
declare_symbol (specifier_t spec, const expr_t *init, symtab_t *symtab,
expr_t *block, rua_ctx_t *ctx)
@ -318,6 +339,21 @@ declare_symbol (specifier_t spec, const expr_t *init, symtab_t *symtab,
if (!shadows_param (sym, symtab)) {
sym->type = find_type (sym->type);
spec.sym = sym;
if (init && init->type != ex_compound && !is_auto (sym->type)) {
auto init_type = get_type (init);
if (!type_same (init_type, sym->type)
&& type_assignable (sym->type, init_type)) {
if (!init_type_ok (sym->type, init)) {
warning (init, "initialization of %s with %s"
" (use a cast)\n)",
get_type_string (spec.type),
get_type_string (init_type));
}
if (init->type != ex_bool) {
init = cast_expr (sym->type, init);
}
}
}
current_target.declare_sym (spec, init, symtab, block);
}
}