qf/quakeforge
0
0
Fork 0
mirror of https://git.code.sf.net/p/quake/quakeforge synced 2024-11-27 06:34:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

Compare symbols using the right method.

Browse source 
That fixme was right :)
This commit is contained in:
Bill Currie 2011-03-03 15:02:26 +09:00
parent 610d775bd1
commit 90640614ef
1 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
tools/qfcc/source/class.c
View file

@ -909,6 +909,20 @@ class_add_ivars (class_t *class, symtab_t *ivars)
class->ivars = ivars;
}
static int
compare_symbols (symbol_t *s1, symbol_t *s2)
{
if (s1->visibility != s2->visibility)
return 0;
if (s1->name != s2->name) // works thanks to save_string
return 0;
if (s1->sy_type != s2->sy_type)
return 0;
if (s1->type != s2->type)
return 0;
return 1;
}
void
class_check_ivars (class_t *class, symtab_t *ivars)
{
@ -919,7 +933,7 @@ class_check_ivars (class_t *class, symtab_t *ivars)
if (ivars) {
for (civ = class->ivars->symbols, iv = ivars->symbols;
civ && iv; civ = civ->next, iv = iv->next) {
if (memcmp (civ, iv, sizeof (*civ))) //FIXME does this work?
if (!compare_symbols (civ, iv))
goto missmatch;
}
}